Add a new GetInstance() method for singleton classes under chrome/service and /net.

net/spdy/spdy_stream.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/spdy/spdy_stream.h"
 
 #include "base/logging.h"
 #include "base/message_loop.h"
 #include "base/singleton.h"
 #include "base/values.h"
@@ skipping 18 matching lines @@
   }
  private:
   const spdy::SpdyStreamId stream_id_;
   const int delta_;
   const int window_size_;
   DISALLOW_COPY_AND_ASSIGN(NetLogSpdyStreamWindowUpdateParameter);
 };
 
 }
 
+ScopedBandwidthMetrics::ScopedBandwidthMetrics()

[ukai, 2010/12/08 01:44:15]

don't we have net/base/bandwidth_metrics.cc ?

I don't think it's good to have an implementation in net/spdy for class defined
in net/base

[willchan no longer on Chromium, 2010/12/08 04:02:47]

Wow, I totally missed this.  I agree completely.

[Satish, 2010/12/08 12:58:22]

We didn't have net/base/bandwidth_metrics.cc and I have added it now with just
this constructor.

+    : metrics_(Singleton<BandwidthMetrics>::get()),
+      started_(false) {
+}
+
 SpdyStream::SpdyStream(SpdySession* session,
                        spdy::SpdyStreamId stream_id,
                        bool pushed,
                        const BoundNetLog& net_log)
     : continue_buffering_data_(true),
       stream_id_(stream_id),
       priority_(0),
       stalled_by_flow_control_(false),
       send_window_size_(spdy::kSpdyStreamInitialWindowSize),
       recv_window_size_(spdy::kSpdyStreamInitialWindowSize),
       pushed_(pushed),
-      metrics_(Singleton<BandwidthMetrics>::get()),
       response_received_(false),
       session_(session),
       delegate_(NULL),
       request_time_(base::Time::Now()),
       response_(new spdy::SpdyHeaderBlock),
       io_state_(STATE_NONE),
       response_status_(OK),
       cancelled_(false),
       has_upload_data_(false),
       net_log_(net_log),
@@ skipping 480 matching lines @@
   UMA_HISTOGRAM_TIMES("Net.SpdyStreamDownloadTime",
       recv_last_byte_time_ - recv_first_byte_time_);
   UMA_HISTOGRAM_TIMES("Net.SpdyStreamTime",
       recv_last_byte_time_ - send_time_);
 
   UMA_HISTOGRAM_COUNTS("Net.SpdySendBytes", send_bytes_);
   UMA_HISTOGRAM_COUNTS("Net.SpdyRecvBytes", recv_bytes_);
 }
 
 }  // namespace net