Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1311)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 5633008: Remove BrowserFileSystemContext class (merge into SandboxedFSContext) (Closed)

Created:
10 years ago by kinuko
Modified:
9 years, 7 months ago
Reviewers:
ericu, michaeln
CC:
chromium-reviews, cbentzel+watch_chromium.org, ben+cc_chromium.org, Erik does not do reviews, jam, kinuko, Aaron Boodman, pam+watch_chromium.org, Paweł Hajdan Jr., darin-cc_chromium.org
Visibility:
Public.

Description

Remove BrowserFileSystemContext class and merge it into SandboxedFileSystemContext BUG=60243 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69089

Patch Set 1 : '' #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+154 lines, -141 lines) Patch
M chrome/browser/extensions/extension_data_deleter.h View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_data_deleter.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extensions_service.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extensions_service_unittest.cc View 1 3 chunks +6 lines, -6 lines 0 comments Download
D chrome/browser/file_system/browser_file_system_context.h View 1 chunk +0 lines, -35 lines 0 comments Download
D chrome/browser/file_system/browser_file_system_context.cc View 1 chunk +0 lines, -34 lines 0 comments Download
A chrome/browser/file_system/browser_file_system_helper.h View 1 chunk +17 lines, -0 lines 0 comments Download
A chrome/browser/file_system/browser_file_system_helper.cc View 1 chunk +23 lines, -0 lines 0 comments Download
M chrome/browser/file_system/file_system_dispatcher_host.h View 1 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/file_system/file_system_dispatcher_host.cc View 1 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/net/chrome_url_request_context.h View 1 6 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/net/chrome_url_request_context.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/profiles/profile.h View 1 3 chunks +17 lines, -12 lines 0 comments Download
M chrome/browser/profiles/profile.cc View 1 3 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/profiles/profile_impl.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/profiles/profile_impl.cc View 1 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/worker_host/worker_process_host.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/testing_profile.h View 1 1 chunk +3 lines, -1 line 0 comments Download
M webkit/fileapi/sandboxed_file_system_context.h View 3 chunks +15 lines, -1 line 0 comments Download
M webkit/fileapi/sandboxed_file_system_context.cc View 3 chunks +21 lines, -0 lines 0 comments Download
M webkit/fileapi/sandboxed_file_system_operation.h View 1 2 chunks +5 lines, -10 lines 0 comments Download
M webkit/fileapi/sandboxed_file_system_operation.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/test_shell/simple_file_system.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/test_shell/simple_file_system.cc View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
kinuko
The change includes many files, but most of them are just doing s/BrowserFileSystemContext/SandboxedFileSystemContext/. This is ...
10 years ago (2010-12-09 22:45:34 UTC) #1
ericu
LGTM
10 years ago (2010-12-10 01:06:04 UTC) #2
michaeln
10 years ago (2010-12-10 20:14:53 UTC) #3 
lgtm2

Powered by Google App Engine
This is Rietveld 408576698