Stops javascript alerts and unload dialogs from showing during

Stops javascript alerts and unload dialogs from showing during
instant.

BUG=65206
TEST=see bug

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68354

[brettw, 2010-12-03 16:48:09]

Are there other types of dialogs? I'm wondering if this should just be one
function to suppress notifications. If you think these might need to be
controlled independently or there are other types of dialogs and are allowed by
your new scheme, I guess one function wouldn't work.

[sky, 2010-12-03 16:54:18]

Popups are handled separately. I don't think there are others, but
there might be. I currently need a switch to turn off all dialogs, so:

TabContents::set_suppress_dialogs(...)

would certainly work. It wouldn't apply to popups. Would you prefer that?

  -Scott

On Fri, Dec 3, 2010 at 8:48 AM,  <brettw@chromium.org> wrote:
> Are there other types of dialogs? I'm wondering if this should just be one
> function to suppress notifications. If you think these might need to be
> controlled independently or there are other types of dialogs and are allowed
> by
> your new scheme, I guess one function wouldn't work.
>
> http://codereview.chromium.org/5631001/
>

[brettw, 2010-12-03 16:57:54]

On Fri, Dec 3, 2010 at 8:54 AM, Scott Violet <sky@chromium.org> wrote:
> Popups are handled separately. I don't think there are others, but
> there might be. I currently need a switch to turn off all dialogs, so:
>
> TabContents::set_suppress_dialogs(...)
>
> would certainly work. It wouldn't apply to popups. Would you prefer that?

How about just one delegate function ShouldSuppressDialogs rather than
two. I think this is better because there are already so many
confusing data members on T.C..

Brett

[sky, 2010-12-03 21:42:50]

Done, new snapshot uploaded.

  -Scott

[brettw, 2010-12-03 21:45:59]

LGTM