Make the AppCacheDispatcherHost be a MessageFilter so that ResourceMessageFil...

Make the AppCacheDispatcherHost be a MessageFilter so that ResourceMessageFilter doesn't have to know about it and vice versa.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68254

[jam, 2010-12-03 23:45:58]

Jenn: do you have time to look at this?  Thanks.

[jennb, 2010-12-04 00:31:51]

Are the appcache layout tests ok with this change?

http://codereview.chromium.org/5625003/diff/12001/chrome/browser/renderer_hos...
File chrome/browser/renderer_host/browser_render_process_host.cc (right):

http://codereview.chromium.org/5625003/diff/12001/chrome/browser/renderer_hos...
chrome/browser/renderer_host/browser_render_process_host.cc:387:
channel_->AddFilter(
Does order of the filters matter?  I.e. would we want AppCacheDispatcherHost to
handle the message before AudioRendererHost?

http://codereview.chromium.org/5625003/diff/12001/chrome/browser/renderer_hos...
File chrome/browser/renderer_host/resource_message_filter.cc (left):

http://codereview.chromium.org/5625003/diff/12001/chrome/browser/renderer_hos...
chrome/browser/renderer_host/resource_message_filter.cc:391:
appcache_dispatcher_host_->OnMessageReceived(msg, &msg_is_ok) ||
Again, wondering about the ordering of who gets the message first.  Should
appcache_dispatcher get the message before dom_storage or indexed_db, etc? 
Seems like with this filter change, appcache would get it after all these other
dispatchers?

http://codereview.chromium.org/5625003/diff/12001/chrome/browser/worker_host/...
File chrome/browser/worker_host/worker_process_host.cc (right):

http://codereview.chromium.org/5625003/diff/12001/chrome/browser/worker_host/...
chrome/browser/worker_host/worker_process_host.cc:226: filters_.push_back(new
AppCacheDispatcherHost(request_context_, id()));
I'm guessing you're switching the other dispatcher hosts to filters in separate
CLs?

http://codereview.chromium.org/5625003/diff/12001/chrome/browser/worker_host/...
chrome/browser/worker_host/worker_process_host.cc:301:
db_dispatcher_host_->OnMessageReceived(message, &msg_is_ok) ||
Will all these also become filters eventually?

[jam, 2010-12-04 00:40:17]

On Fri, Dec 3, 2010 at 4:31 PM, <jennb@chromium.org> wrote:

> Are the appcache layout tests ok with this change?
>

all trybots are green

>
>
>
>
http://codereview.chromium.org/5625003/diff/12001/chrome/browser/renderer_hos...
> File chrome/browser/renderer_host/browser_render_process_host.cc
> (right):
>
>
>
http://codereview.chromium.org/5625003/diff/12001/chrome/browser/renderer_hos...
> chrome/browser/renderer_host/browser_render_process_host.cc:387:
> channel_->AddFilter(
> Does order of the filters matter?  I.e. would we want
> AppCacheDispatcherHost to handle the message before AudioRendererHost?


>
>
http://codereview.chromium.org/5625003/diff/12001/chrome/browser/renderer_hos...
> File chrome/browser/renderer_host/resource_message_filter.cc (left):
>
>
>
http://codereview.chromium.org/5625003/diff/12001/chrome/browser/renderer_hos...
> chrome/browser/renderer_host/resource_message_filter.cc:391:
> appcache_dispatcher_host_->OnMessageReceived(msg, &msg_is_ok) ||
> Again, wondering about the ordering of who gets the message first.
> Should appcache_dispatcher get the message before dom_storage or
> indexed_db, etc?  Seems like with this filter change, appcache would get
> it after all these other dispatchers?
>

The ordering doesn't matter, since each filter consumes different messages.


>
>
>
http://codereview.chromium.org/5625003/diff/12001/chrome/browser/worker_host/...
> File chrome/browser/worker_host/worker_process_host.cc (right):
>
>
>
http://codereview.chromium.org/5625003/diff/12001/chrome/browser/worker_host/...
> chrome/browser/worker_host/worker_process_host.cc:226:
> filters_.push_back(new AppCacheDispatcherHost(request_context_, id()));
> I'm guessing you're switching the other dispatcher hosts to filters in
> separate CLs?
>

right


>
>
>
http://codereview.chromium.org/5625003/diff/12001/chrome/browser/worker_host/...
> chrome/browser/worker_host/worker_process_host.cc:301:
> db_dispatcher_host_->OnMessageReceived(message, &msg_is_ok) ||
> Will all these also become filters eventually?


yes everything will be split off, i'm just doing it in steps


>
>
> http://codereview.chromium.org/5625003/
>

[jennb, 2010-12-04 00:42:05]

LGTM

IM'd with John - test_shell tests unaffected by this change. Order doesn't
matter because the filters handle different messages.