Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 5625: Fix issue 86 by keeping track of the fact that finally blocks... (Closed)

Created:
12 years, 2 months ago by Kasper Lund
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Fix issue 86 by keeping track of the fact that finally blocks are evaluated with an extra element on the stack, which needs to be taken into account when breaking and continuing. I'll clean up the code and add an abstraction for manipulating the break stack height in a future CL -- I want to try to get rid of the separate local variable we keep around for the "state" when running in a finally block. Committed: http://code.google.com/p/v8/source/detail?r=400

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -48 lines) Patch
M src/codegen-arm.cc View 2 chunks +12 lines, -1 line 0 comments Download
M src/codegen-ia32.cc View 3 chunks +10 lines, -1 line 0 comments Download
D test/mjsunit/bugs/bug-86.js View 1 chunk +0 lines, -44 lines 0 comments Download
A + test/mjsunit/regress/regress-86.js View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kasper Lund
12 years, 2 months ago (2008-10-01 07:36:57 UTC) #1
Christian Plesner Hansen
12 years, 2 months ago (2008-10-01 07:40:55 UTC) #2
Lgtm!

Powered by Google App Engine
This is Rietveld 408576698