Restructure the structs/unions involved in SRPC argument passing. This will...

src/trusted/plugin/ppapi/var_utils.cc

 /*
  * Copyright 2010 The Native Client Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can
  * be found in the LICENSE file.
  */
 
 
 #include <assert.h>
 
 #include "native_client/src/trusted/plugin/ppapi/var_utils.h"
@@ skipping 193 matching lines @@
   switch (arg->tag) {
     case NACL_SRPC_ARG_TYPE_BOOL:
     case NACL_SRPC_ARG_TYPE_DOUBLE:
     case NACL_SRPC_ARG_TYPE_INT:
     case NACL_SRPC_ARG_TYPE_LONG:
     case NACL_SRPC_ARG_TYPE_STRING:
     case NACL_SRPC_ARG_TYPE_HANDLE:
     case NACL_SRPC_ARG_TYPE_OBJECT:
       break;  // nothing to do
     case NACL_SRPC_ARG_TYPE_CHAR_ARRAY:
-      PPVarToAllocateArray(var, &arg->u.caval.count, &arg->u.caval.carr,
-                           exception);
+      PPVarToAllocateArray(var, &arg->u.count, &arg->arrays.carr, exception);
       break;
     case NACL_SRPC_ARG_TYPE_DOUBLE_ARRAY:
-      PPVarToAllocateArray(var, &arg->u.daval.count, &arg->u.daval.darr,
-                           exception);
+      PPVarToAllocateArray(var, &arg->u.count, &arg->arrays.darr, exception);
       break;
     case NACL_SRPC_ARG_TYPE_INT_ARRAY:
-      PPVarToAllocateArray(var, &arg->u.iaval.count, &arg->u.iaval.iarr,
-                           exception);
+      PPVarToAllocateArray(var, &arg->u.count, &arg->arrays.iarr, exception);
       break;
     case NACL_SRPC_ARG_TYPE_LONG_ARRAY:
-      PPVarToAllocateArray(var, &arg->u.laval.count, &arg->u.laval.larr,
-                           exception);
+      PPVarToAllocateArray(var, &arg->u.count, &arg->arrays.larr, exception);
       break;
     case NACL_SRPC_ARG_TYPE_VARIANT_ARRAY:
     case NACL_SRPC_ARG_TYPE_INVALID:
     default:
       *exception = "variant array and invalid type arguments are not supported";
   }
   PLUGIN_PRINTF(("  PPVarToAllocateNaClSrpcArg (return exception=%s)\n",
                  exception->DebugString().c_str()));
   return exception->is_undefined();
 }
@@ skipping 14 matching lines @@
     case NACL_SRPC_ARG_TYPE_DOUBLE:
       arg->u.dval = PPVarToNumber<double>(var, exception);
       break;
     case NACL_SRPC_ARG_TYPE_INT:
       arg->u.ival = PPVarToNumber<int32_t>(var, exception);
       break;
     case NACL_SRPC_ARG_TYPE_LONG:
       arg->u.lval = PPVarToNumber<int64_t>(var, exception);
       break;
     case NACL_SRPC_ARG_TYPE_STRING:
-      arg->u.sval.str = PPVarToString(var, exception);
+      arg->arrays.str = PPVarToString(var, exception);
       break;
     case NACL_SRPC_ARG_TYPE_CHAR_ARRAY:
-      PPVarToArray(var, &arg->u.caval.count, &arg->u.caval.carr, exception);
+      PPVarToArray(var, &arg->u.count, &arg->arrays.carr, exception);
       break;
     case NACL_SRPC_ARG_TYPE_DOUBLE_ARRAY:
-      PPVarToArray(var, &arg->u.daval.count, &arg->u.daval.darr, exception);
+      PPVarToArray(var, &arg->u.count, &arg->arrays.darr, exception);
       break;
     case NACL_SRPC_ARG_TYPE_INT_ARRAY:
-      PPVarToArray(var, &arg->u.iaval.count, &arg->u.iaval.iarr, exception);
+      PPVarToArray(var, &arg->u.count, &arg->arrays.iarr, exception);
       break;
     case NACL_SRPC_ARG_TYPE_LONG_ARRAY:
-      PPVarToArray(var, &arg->u.laval.count, &arg->u.laval.larr, exception);
+      PPVarToArray(var, &arg->u.count, &arg->arrays.larr, exception);
       break;
     case NACL_SRPC_ARG_TYPE_HANDLE:
       arg->u.hval = reinterpret_cast<NaClSrpcImcDescType>(
           PPVarToNaClDesc(var, exception));
       break;
     case NACL_SRPC_ARG_TYPE_OBJECT:
-      arg->u.oval = reinterpret_cast<void*>(
+      arg->arrays.oval = reinterpret_cast<void*>(
           PPVarToScriptableHandle(var, exception));
       // There are currently no predeclared PPAPI plugin methods that
       // take objects as input, so this should never be reached.
       NACL_NOTREACHED();
       break;
     case NACL_SRPC_ARG_TYPE_VARIANT_ARRAY:
     case NACL_SRPC_ARG_TYPE_INVALID:
     default:
       *exception = "variant array and invalid type arguments are not supported";
   }
@@ skipping 100 matching lines @@
       var = pp::Var(arg->u.dval);
       break;
     case NACL_SRPC_ARG_TYPE_INT:
       var = pp::Var(arg->u.ival);
       break;
     case NACL_SRPC_ARG_TYPE_LONG:
       // PPAPI does not have a 64-bit integral type.  Downcast.
       var = pp::Var(static_cast<int32_t>(arg->u.lval));
       break;
     case NACL_SRPC_ARG_TYPE_STRING:
-      var = pp::Var(arg->u.sval.str);
+      var = pp::Var(arg->arrays.str);
       break;
     case NACL_SRPC_ARG_TYPE_CHAR_ARRAY:
-      var = ArrayToPPVar(arg->u.caval.carr, arg->u.caval.count, plugin,
-                         exception);
+      var = ArrayToPPVar(arg->arrays.carr, arg->u.count, plugin, exception);
       break;
     case NACL_SRPC_ARG_TYPE_DOUBLE_ARRAY:
-      var = ArrayToPPVar(arg->u.daval.darr, arg->u.daval.count, plugin,
-                        exception);
+      var = ArrayToPPVar(arg->arrays.darr, arg->u.count, plugin, exception);
       break;
     case NACL_SRPC_ARG_TYPE_INT_ARRAY:
-      var = ArrayToPPVar(arg->u.iaval.iarr, arg->u.iaval.count, plugin,
-                         exception);
+      var = ArrayToPPVar(arg->arrays.iarr, arg->u.count, plugin, exception);
       break;
     case NACL_SRPC_ARG_TYPE_LONG_ARRAY:
-      var = ArrayToPPVar(arg->u.laval.larr, arg->u.laval.count, plugin,
-                         exception);
+      var = ArrayToPPVar(arg->arrays.larr, arg->u.count, plugin, exception);
       break;
     case NACL_SRPC_ARG_TYPE_HANDLE:
       var = NaClDescToPPVar(arg->u.hval, plugin, exception);
       break;
     case NACL_SRPC_ARG_TYPE_OBJECT:
-      var = ObjectToPPVar(arg->u.oval);
+      var = ObjectToPPVar(arg->arrays.oval);
       break;
     case NACL_SRPC_ARG_TYPE_VARIANT_ARRAY:
     case NACL_SRPC_ARG_TYPE_INVALID:
     default:
       *exception = "variant array and invalid argument types are not supproted";
   }
   PLUGIN_PRINTF(("  NaClSrpcArgToPPVar (return var=%s, exception=%s)\n",
                  var.DebugString().c_str(), exception->DebugString().c_str()));
   return var;
 }
 
 }  // namespace plugin