Issue 5622001: Make sure we don't keep tab id - handles mapping when a dread dies....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5622001: Make sure we don't keep tab id - handles mapping when a dread dies.... (Closed)

Created:
10 years ago by MAD

Modified:
9 years, 7 months ago

Reviewers:
Jói, hansl, Sigurður Ásgeirsson

CC:
chromium-reviews, ceee-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Make sure we don't keep tab id - handles mapping when a thread dies. BUG=65153 TEST=See hard to repro scenario in bug... Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68298

Patch Set 1 #

Total comments: 1

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+64 lines, -3 lines)			Patch
M	ceee/ie/broker/chrome_postman.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	ceee/ie/broker/chrome_postman.cc	View	2 chunks	+11 lines, -1 line	0 comments	Download
M	ceee/ie/broker/executors_manager.h	View	2 chunks	+5 lines, -0 lines	0 comments	Download
M	ceee/ie/broker/executors_manager.cc	View	5 chunks	+45 lines, -2 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Sigurður Ásgeirsson

lgtm http://codereview.chromium.org/5622001/diff/1/ceee/ie/broker/executors_manager.cc File ceee/ie/broker/executors_manager.cc (right): http://codereview.chromium.org/5622001/diff/1/ceee/ie/broker/executors_manager.cc#newcode631 ceee/ie/broker/executors_manager.cc:631: // We must asynchronously post this change in ...

10 years ago (2010-12-03 20:40:42 UTC) #2

MAD

Yeah, I would have preferred to clean the map instantly when the thread dies, but ...

10 years ago (2010-12-04 17:27:30 UTC) #3

LGTM

Expand Messages | Collapse Messages