Issue 562039: linux: make NSS version check non-fatal

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 562039: linux: make NSS version check non-fatal (Closed)

Created:
10 years, 10 months ago by Evan Martin

Modified:
9 years, 7 months ago

Reviewers:
wtc

CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org

Visibility:
Public.

Description

linux: make NSS version check non-fatal It broke too many people for reasons outside of their control. BUG=33163 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=39436

Patch Set 1 #

Total comments: 1

Patch Set 2 : with nspr message #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -3 lines)			Patch
	M	base/nss_util.cc	View	1	1 chunk	+12 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

wtc

10 years, 10 months ago (2010-02-04 02:43:54 UTC) #2

LGTM.  Please make the suggested change below.

http://codereview.chromium.org/562039/diff/1/2
File base/nss_util.cc (right):

http://codereview.chromium.org/562039/diff/1/2#newcode100
base/nss_util.cc:100: "Please upgrade to the latest NSS, and if you still get "
Change
    the latest NSS
to
    the latest NSS and NSPR

Expand Messages | Collapse Messages