Issue 562034: Updated JSON.stringify to newest version of ES5.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 562034: Updated JSON.stringify to newest version of ES5. (Closed)

Created:
10 years, 10 months ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
Rico

CC:
v8-dev

Visibility:
Public.

Description

Updated JSON.stringify to newest version of ES5.

Patch Set 1 #

Total comments: 4

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -12 lines)			Patch
	M	src/json-delay.js	View		6 chunks	+23 lines, -10 lines	0 comments	Download
	M	test/mjsunit/json.js	View		3 chunks	+20 lines, -2 lines	4 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Rico

LGMT http://codereview.chromium.org/562034/diff/1/3 File test/mjsunit/json.js (right): http://codereview.chromium.org/562034/diff/1/3#newcode298 test/mjsunit/json.js:298: Maybe check for stringify on an array with ...

10 years, 10 months ago (2010-02-03 12:57:22 UTC) #2

Lasse Reichstein

10 years, 10 months ago (2010-02-03 13:18:29 UTC) #3

http://codereview.chromium.org/562034/diff/1/3
File test/mjsunit/json.js (right):

http://codereview.chromium.org/562034/diff/1/3#newcode298
test/mjsunit/json.js:298: 
Check added for behavior of undefined and functions in both arrays and objects.

http://codereview.chromium.org/562034/diff/1/3#newcode299
test/mjsunit/json.js:299: assertThrows("var a = [];a[0] = a;JSON.stringify(a);",
TypeError);
We do. Removed.

Expand Messages | Collapse Messages