Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 562031: Fix licensing headers and move most third party code to third_party/... (Closed)

Created:
10 years, 10 months ago by M-A Ruel
Modified:
5 years, 5 months ago
CC:
chromium-reviews, Nasser Grainawi
Visibility:
Public.

Description

Fix licensing headers and move most third party code to third_party/ Moved tests/pymox to third_party/pymox Moved upload.py to third_party/upload.py Fixed tests so they can run standalone Fixed the executable bit on some scripts TEST=none BUG=34376 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=37987

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -5714 lines) Patch
MM PRESUBMIT.py View 1 chunk +0 lines, -1 line 0 comments Download
M README View 3 chunks +1 line, -8 lines 0 comments Download
D README.git-cl View 1 chunk +0 lines, -52 lines 0 comments Download
D README.git-cl.codereview View 1 chunk +0 lines, -99 lines 0 comments Download
MM drover.py View 2 chunks +2 lines, -1 line 0 comments Download
M gcl.py View 1 chunk +1 line, -1 line 0 comments Download
M gclient.py View 1 chunk +3 lines, -14 lines 0 comments Download
M git-try View 2 chunks +2 lines, -5 lines 0 comments Download
MM presubmit_canned_checks.py View 1 chunk +1 line, -2 lines 0 comments Download
D tests/README.gclient_test View 1 chunk +0 lines, -6 lines 0 comments Download
M tests/gcl_unittest.py View 1 chunk +4 lines, -3 lines 0 comments Download
M tests/gclient_scm_test.py View 4 chunks +12 lines, -21 lines 1 comment Download
M tests/gclient_test.py View 1 chunk +5 lines, -19 lines 0 comments Download
MM tests/gclient_utils_test.py View 2 chunks +5 lines, -4 lines 0 comments Download
M tests/presubmit_unittest.py View 2 chunks +5 lines, -3 lines 0 comments Download
D tests/pymox/COPYING View 1 chunk +0 lines, -202 lines 0 comments Download
D tests/pymox/MANIFEST.in View 1 chunk +0 lines, -5 lines 0 comments Download
D tests/pymox/README View 1 chunk +0 lines, -56 lines 0 comments Download
D tests/pymox/mox.py View 1 chunk +0 lines, -1643 lines 0 comments Download
D tests/pymox/mox_test.py View 1 chunk +0 lines, -1708 lines 0 comments Download
D tests/pymox/mox_test_helper.py View 1 chunk +0 lines, -76 lines 0 comments Download
D tests/pymox/setup.py View 1 chunk +0 lines, -14 lines 0 comments Download
D tests/pymox/stubout.py View 1 chunk +0 lines, -142 lines 0 comments Download
D tests/pymox/stubout_test.py View 1 chunk +0 lines, -47 lines 0 comments Download
D tests/pymox/stubout_testee.py View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/scm_unittest.py View 2 chunks +6 lines, -4 lines 0 comments Download
M tests/super_mox.py View 1 4 chunks +10 lines, -3 lines 0 comments Download
MM tests/trychange_unittest.py View 2 chunks +4 lines, -5 lines 0 comments Download
A third_party/__init__.py View 1 chunk +5 lines, -0 lines 0 comments Download
A + third_party/upload.py View 0 chunks +-1 lines, --1 lines 0 comments Download
D upload.py View 1 chunk +0 lines, -1569 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
M-A Ruel
10 years, 10 months ago (2010-02-03 03:02:09 UTC) #1
Nicolas Sylvain
lg http://codereview.chromium.org/562031/diff/2001/2022 File tests/gclient_scm_test.py (right): http://codereview.chromium.org/562031/diff/2001/2022#newcode10 tests/gclient_scm_test.py:10: from shutil import rmtree why?
10 years, 10 months ago (2010-02-03 18:07:18 UTC) #2
18runt88
lgtm
5 years, 5 months ago (2015-07-15 01:44:15 UTC) #4
18runt88
lgtm
5 years, 5 months ago (2015-07-15 01:44:26 UTC) #5
18runt88
lgtm
5 years, 5 months ago (2015-07-15 01:44:55 UTC) #6
18runt88
5 years, 5 months ago (2015-07-15 02:09:51 UTC) #7
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698