Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 5620004: chromeos: Show onscreen bubble when brightness changes. (Closed)

Created:
10 years ago by Daniel Erat
Modified:
9 years, 7 months ago
Reviewers:
glotov, Charlie Lee
CC:
chromium-reviews, davemoore+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

chromeos: Show onscreen bubble when brightness changes. This adds a BrightnessLibrary class that registers to receive notification of brightness changes from the libcros code that I added in http://codereview.chromium.org/5640003/, a BrightnessBubble class to control an onscreen indicator of the current brightness level, and a BrightnessObserver class that wires up the two. This change depends on http://codereview.chromium.org/5603012/, which pulls the updated version of libcros into Chrome. BUG=chromium-os:8473, chromium-os:4816 TEST=built and tried it Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68879

Patch Set 1 #

Patch Set 2 : more changes #

Patch Set 3 : remove unnecessary includes #

Total comments: 1

Patch Set 4 : update comment #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+275 lines, -2 lines) Patch
M chrome/app/theme/theme_resources.grd View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/browser/chromeos/brightness_bubble.h View 1 2 3 1 chunk +32 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/brightness_bubble.cc View 1 2 3 1 chunk +28 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/brightness_observer.h View 1 1 chunk +30 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/brightness_observer.cc View 1 2 1 chunk +17 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/cros/brightness_library.h View 1 1 chunk +32 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/cros/brightness_library.cc View 1 2 3 1 chunk +93 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/cros/cros_library.h View 4 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/cros/cros_library.cc View 3 chunks +10 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/setting_level_bubble.h View 1 2 chunks +2 lines, -0 lines 2 comments Download
M chrome/browser/chromeos/setting_level_bubble.cc View 1 chunk +5 lines, -1 line 0 comments Download
M chrome/browser/chromeos/system_key_event_listener.cc View 1 4 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/volume_bubble.h View 1 2 3 1 chunk +1 line, -0 lines 1 comment Download
M chrome/browser/ui/browser_init.cc View 1 3 chunks +7 lines, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Daniel Erat
10 years ago (2010-12-08 18:40:53 UTC) #1
glotov
LGTM http://codereview.chromium.org/5620004/diff/5001/chrome/browser/chromeos/cros/brightness_library.cc File chrome/browser/chromeos/cros/brightness_library.cc (right): http://codereview.chromium.org/5620004/diff/5001/chrome/browser/chromeos/cros/brightness_library.cc#newcode92 chrome/browser/chromeos/cros/brightness_library.cc:92: // Allows InvokeLater without adding refcounting. This class ...
10 years ago (2010-12-09 18:46:13 UTC) #2
Daniel Erat
On 2010/12/09 18:46:13, glotov wrote: > LGTM > > http://codereview.chromium.org/5620004/diff/5001/chrome/browser/chromeos/cros/brightness_library.cc > File chrome/browser/chromeos/cros/brightness_library.cc (right): > ...
10 years ago (2010-12-09 21:27:23 UTC) #3
Charlie Lee
LGTM with comments http://codereview.chromium.org/5620004/diff/10001/chrome/browser/chromeos/setting_level_bubble.h File chrome/browser/chromeos/setting_level_bubble.h (right): http://codereview.chromium.org/5620004/diff/10001/chrome/browser/chromeos/setting_level_bubble.h#newcode11 chrome/browser/chromeos/setting_level_bubble.h:11: #include "base/basictypes.h" is this new include ...
10 years ago (2010-12-09 21:35:04 UTC) #4
Daniel Erat
http://codereview.chromium.org/5620004/diff/10001/chrome/browser/chromeos/setting_level_bubble.h File chrome/browser/chromeos/setting_level_bubble.h (right): http://codereview.chromium.org/5620004/diff/10001/chrome/browser/chromeos/setting_level_bubble.h#newcode11 chrome/browser/chromeos/setting_level_bubble.h:11: #include "base/basictypes.h" On 2010/12/09 21:35:04, Charlie Lee wrote: > ...
10 years ago (2010-12-09 21:43:54 UTC) #5
Charlie Lee
10 years ago (2010-12-09 22:25:52 UTC) #6 
Ok, LGTM

- Charlie


On Thu, Dec 9, 2010 at 1:43 PM, <derat@chromium.org> wrote:

>
>
>
http://codereview.chromium.org/5620004/diff/10001/chrome/browser/chromeos/set...
> File chrome/browser/chromeos/setting_level_bubble.h (right):
>
>
>
http://codereview.chromium.org/5620004/diff/10001/chrome/browser/chromeos/set...
> chrome/browser/chromeos/setting_level_bubble.h:11: #include
> "base/basictypes.h"
> On 2010/12/09 21:35:04, Charlie Lee wrote:
>
>> is this new include needed?
>>
>
> It provides DISALLOW_COPY_AND_ASSIGN().  (We get basictypes.h indirectly
> from earlier includes, but it ought to be explicitly listed since we
> depend on it.)
>
>
> http://codereview.chromium.org/5620004/
>

Powered by Google App Engine
This is Rietveld 408576698