Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 56198: Roll out dominantScript, getGenericFontForScript patches to unfork a bunch of... (Closed)

Created:
11 years, 8 months ago by dglazkov
Modified:
9 years, 6 months ago
Reviewers:
jungshik at Google
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Roll out dominantScript, getGenericFontForScript patches to unfork a bunch of files, WebKit side. These patches are now tracked upstream: http://bugs.webkit.org/show_bug.cgi?id=20797 http://bugs.webkit.org/show_bug.cgi?id=10874 http://bugs.webkit.org/show_bug.cgi?id=18085 R=jshin BUG=9768 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=13156

Patch Set 1 #

Total comments: 6

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -296 lines) Patch
M third_party/WebKit/WebCore/css/CSSStyleSelector.cpp View 1 2 3 6 chunks +12 lines, -88 lines 0 comments Download
M third_party/WebKit/WebCore/dom/Document.h View 1 4 chunks +1 line, -20 lines 0 comments Download
M third_party/WebKit/WebCore/dom/Document.cpp View 1 7 chunks +1 line, -106 lines 0 comments Download
M third_party/WebKit/WebCore/platform/graphics/FontCache.h View 1 2 chunks +0 lines, -8 lines 0 comments Download
M third_party/WebKit/WebCore/platform/graphics/FontDescription.h View 1 5 chunks +0 lines, -6 lines 0 comments Download
M third_party/WebKit/WebCore/platform/graphics/chromium/FontCacheChromiumWin.cpp View 1 2 chunks +0 lines, -15 lines 0 comments Download
M third_party/WebKit/WebCore/platform/graphics/chromium/FontCacheLinux.cpp View 1 1 chunk +0 lines, -7 lines 0 comments Download
M third_party/WebKit/WebCore/platform/graphics/mac/FontCacheMac.mm View 1 2 chunks +0 lines, -17 lines 0 comments Download
M third_party/WebKit/WebCore/rendering/RenderTheme.h View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/WebCore/rendering/RenderThemeChromiumLinux.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/WebCore/rendering/RenderThemeChromiumLinux.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/WebCore/rendering/RenderThemeChromiumMac.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/WebCore/rendering/RenderThemeChromiumMac.mm View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/WebCore/rendering/RenderThemeChromiumWin.h View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/WebCore/rendering/RenderThemeChromiumWin.cpp View 1 4 chunks +4 lines, -20 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
dglazkov
11 years, 8 months ago (2009-04-02 20:47:10 UTC) #1
jungshik at Google
lgtm with the following unrelated changes removed (for an easier tracking later). Also, can you ...
11 years, 8 months ago (2009-04-02 21:20:58 UTC) #2
dglazkov
11 years, 8 months ago (2009-04-06 16:12:56 UTC) #3
Thanks for reviewing this! Done and committed.

http://codereview.chromium.org/56198/diff/1/12
File third_party/WebKit/WebCore/css/CSSStyleSelector.cpp (left):

http://codereview.chromium.org/56198/diff/1/12#oldcode1516
Line 1516: style->setOverflowY(style->overflowY() == OVISIBLE ? OAUTO :
style->overflowY());
On 2009/04/02 21:20:58, Jungshik Shin wrote:
> At least, this should be in a separate CL. This part is not related to the
rest
> of roll-out/unforking. 
> 

Done.

http://codereview.chromium.org/56198/diff/1/2
File third_party/WebKit/WebCore/dom/Document.cpp (left):

http://codereview.chromium.org/56198/diff/1/2#oldcode163
Line 163: #define WTF_PLATFORM_CHROMIUM 1
On 2009/04/02 21:20:58, Jungshik Shin wrote:
> Again, this change is not related to the rest of changes. So, it'd better be
in
> a different CL, I think.

Done.

http://codereview.chromium.org/56198/diff/1/2
File third_party/WebKit/WebCore/dom/Document.cpp (right):

http://codereview.chromium.org/56198/diff/1/2#newcode4275
Line 4275: if (equalIgnoringCase(dnsPrefetchControl, "on") &&
!m_haveExplicitlyDisabledDNSPrefetch) {
On 2009/04/02 21:20:58, Jungshik Shin wrote:
> same here. 

Done.

Powered by Google App Engine
This is Rietveld 408576698