Issue 56193: Bug 2220: Fix for missing Find highlighting after Refresh

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 56193: Bug 2220: Fix for missing Find highlighting after Refresh (Closed)

Created:
11 years, 8 months ago by Finnur

Modified:
9 years, 6 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Bug 2220 lists two cases where the inactive highlighting doesn't reappear on FindNext. This is a simple fix for one of those cases (user presses Refresh after Find). BUG=2220 TEST=Open google.com, press Find, press e, press Refresh, press F3 (or FindNext button in UI). Then make sure the inactive matches are highlighted (not just the active match). Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=13028

Patch Set 1 #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -6 lines)			Patch
	M	chrome/browser/find_bar_controller.cc	View		1 chunk	+9 lines, -4 lines	0 comments	Download
	M	chrome/browser/tab_contents/web_contents.h	View		3 chunks	+9 lines, -2 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages