Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 5619002: Revert 68094 - Refactoring BufferedDataSource to work with WebURLLoader inste... (Closed)

Created:
10 years ago by scherkus (not reviewing)
Modified:
9 years, 7 months ago
CC:
chromium-reviews, vrk (LEFT CHROMIUM), fbarchard, ddorwin+watch_chromium.org, Alpha Left Google, jam, brettw-cc_chromium.org, acolwell GONE FROM CHROMIUM, annacc, darin-cc_chromium.org, awong, Paweł Hajdan Jr., pam+watch_chromium.org, stuartmorgan+watch_chromium.org, scherkus (not reviewing)
Visibility:
Public.

Description

Revert 68094 - Refactoring BufferedDataSource to work with WebURLLoader instead of a MediaResourceLoaderBridge. One thing to notice is that both buffered_data_source_unittest and simple_data_source_unittest need to have a way to inject a MockWebURLLoader into the BufferedResourceLoader and the SimpleDataSource. In order to make sure a new one is not created during a Start(), I introduced the function SetURLLoaderForTest and keep_test_loader flag. Patch by annacc@chromium.org: http://codereview.chromium.org/3863002/ BUG=16751 TEST=src/xcodebuild/Debug/test_shell_tests --gtest_filter=Buffered* src/xcodebuild/Debug/test_shell_tests --gtest_filter=Simple* src/webkit/tools/layout_tests/run_webkit_tests.sh --debug media webkit/tools/layout_tests/run_webkit_tests.sh --debug http/tests/media TBR=scherkus@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68126

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+485 lines, -1005 lines) Patch
M chrome/renderer/render_view.cc View 2 chunks +24 lines, -4 lines 0 comments Download
M webkit/glue/media/buffered_data_source.h View 8 chunks +37 lines, -70 lines 0 comments Download
M webkit/glue/media/buffered_data_source.cc View 27 chunks +111 lines, -196 lines 0 comments Download
M webkit/glue/media/buffered_data_source_unittest.cc View 27 chunks +129 lines, -96 lines 0 comments Download
M webkit/glue/media/simple_data_source.h View 5 chunks +24 lines, -48 lines 0 comments Download
M webkit/glue/media/simple_data_source.cc View 9 chunks +35 lines, -92 lines 0 comments Download
M webkit/glue/media/simple_data_source_unittest.cc View 7 chunks +53 lines, -42 lines 0 comments Download
D webkit/glue/mock_webframe.h View 1 chunk +0 lines, -352 lines 0 comments Download
D webkit/glue/mock_weburlloader_impl.h View 1 chunk +0 lines, -36 lines 0 comments Download
M webkit/glue/multipart_response_delegate.h View 1 chunk +1 line, -2 lines 0 comments Download
M webkit/glue/multipart_response_delegate.cc View 3 chunks +10 lines, -34 lines 0 comments Download
M webkit/glue/multipart_response_delegate_unittest.cc View 4 chunks +4 lines, -12 lines 0 comments Download
M webkit/glue/plugins/webplugin_impl.cc View 1 chunk +1 line, -3 lines 0 comments Download
M webkit/glue/webmediaplayer_impl.h View 2 chunks +2 lines, -5 lines 0 comments Download
M webkit/glue/webmediaplayer_impl.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M webkit/support/webkit_support.cc View 1 chunk +25 lines, -4 lines 0 comments Download
M webkit/tools/test_shell/test_shell.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M webkit/tools/test_shell/test_webview_delegate.cc View 1 chunk +25 lines, -4 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
scherkus (not reviewing)
10 years ago (2010-12-03 01:48:03 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698