Put back compilation cache

Put back compilation cache

[iposva, 2009-04-02 18:24:16]

Small comments, otherwise LGTM.

-Ivan

http://codereview.chromium.org/56185/diff/1/4
File src/compilation-cache.cc (right):

http://codereview.chromium.org/56185/diff/1/4#newcode101
Line 101: // script originates from the same places. This is to avoid issues
places -> place?

http://codereview.chromium.org/56185/diff/1/4#newcode105
Line 105: // when reporting errors, etc.
Duplicated comment.

http://codereview.chromium.org/56185/diff/1/4#newcode148
Line 148: int column_offset) {
Please refer to the bug 254 in a TODO here.

[Kasper Lund, 2009-04-03 05:56:38]

LGTM. Thanks.

[DaveMoore, 2009-04-06 18:08:23]

http://codereview.chromium.org/56185/diff/1/4
File src/compilation-cache.cc (right):

http://codereview.chromium.org/56185/diff/1/4#newcode101
Line 101: // script originates from the same places. This is to avoid issues
On 2009/04/02 18:24:16, iposva wrote:
> places -> place?

Done.

http://codereview.chromium.org/56185/diff/1/4#newcode105
Line 105: // when reporting errors, etc.
On 2009/04/02 18:24:16, iposva wrote:
> Duplicated comment.

Done.

http://codereview.chromium.org/56185/diff/1/4#newcode148
Line 148: int column_offset) {
Done, but the details are slightly different. We won't share code accidentally
across contexts, but if a second identical script is compiled (from a different
source / line) it won't use the cached copy and won't be cached itself.

[iposva, 2009-04-06 18:11:20]

http://codereview.chromium.org/56185/diff/1/4
File src/compilation-cache.cc (right):

http://codereview.chromium.org/56185/diff/1/4#newcode148
Line 148: int column_offset) {
On 2009/04/06 18:08:23, davemoore wrote:
> Done, but the details are slightly different. We won't share code accidentally
> across contexts, but if a second identical script is compiled (from a
different
> source / line) it won't use the cached copy and won't be cached itself.
> 

I must be missing how you protect against sharing code in two contexts.