Issue 56180: Use -Wl,-{start,end}-group for LoadableModules, too.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 56180: Use -Wl,-{start,end}-group for LoadableModules, too. (Closed)

Created:
11 years, 8 months ago by sgk

Modified:
9 years, 5 months ago

Reviewers:
Mark Mentovai

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Use -Wl,-{start,end}-group for LoadableModules, too. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=13013

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	build/common.gypi	View	1	2 chunks	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

sgk

11 years, 8 months ago (2009-04-02 16:07:08 UTC) #1

This broke when we switched the gyp type to loadable_module.  Previously we were
building these as shared libraries, which had the -Wl,-{start,end}-group in the
link line.  Switching to LoadableModule() started using the $LDMODULECOM command
line taht we previously weren't using and had never had the
-Wl,-{start,end}-group added.

Expand Messages | Collapse Messages