Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Issue 5617004: Adding SSL mutex specification to a local file, to stop relying on a mutable... (Closed)

Created:
10 years ago by Peter Mayo
Modified:
9 years, 7 months ago
Reviewers:
tony, M-A Ruel
CC:
chromium-reviews, pam+watch_chromium.org, Nicolas Sylvain
Visibility:
Public.

Description

Adding SSL mutex specification to a local file, to stop relying on a mutable directory in the root. TEST=Locally on a bot like machine (no prior fix). Try bots (with chmod /var/run). BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68312

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M tools/python/google/platform_utils_linux.py View 1 2 chunks +2 lines, -0 lines 0 comments Download
M tools/python/google/platform_utils_mac.py View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
tony
The code change looks fine, but what test uses this code? I thought we didn't ...
10 years ago (2010-12-03 18:15:30 UTC) #1
Peter Mayo
On 2010/12/03 18:15:30, tony wrote: > The code change looks fine, but what test uses ...
10 years ago (2010-12-03 18:23:45 UTC) #2
Peter Mayo
On 2010/12/03 18:23:45, Peter Mayo wrote: > On 2010/12/03 18:15:30, tony wrote: > > The ...
10 years ago (2010-12-03 19:33:11 UTC) #3
tony
10 years ago (2010-12-03 19:33:22 UTC) #4
Ah, dom_checker_tests.  I didn't know about these tests.  This change LGTM. 
Seems better than having to manually run chmod /var/run/ on all the bots.

On 2010/12/03 18:23:45, Peter Mayo wrote:
> On 2010/12/03 18:15:30, tony wrote:
> > The code change looks fine, but what test uses this code?  I thought we
didn't
> > use apache on windows.
> 
> The windows and mac need is under investigation - I thought I would start by
> erring on the highlight it side.  If you believe it is not necessary on
windows,
> I will remove _win.
> 
> Do you have knowledge of it's use or lack thereof in dom_checker_tests on mac?
 
> 
>
http://build.chromium.org/p/chromium.fyi/builders/Chromium%2520Linux%2520Touc...
>  shows the problem on Linux.

Powered by Google App Engine
This is Rietveld 408576698