Issue 56167: Second part of fix of issue http://code.google.com/p/chromium/issues/detail?i...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 56167: Second part of fix of issue http://code.google.com/p/chromium/issues/detail?i... (Closed)

Created:
11 years, 8 months ago by Feng Qian

Modified:
9 years, 7 months ago

Reviewers:
mbelshe, Mads Ager (chromium)

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Second part of fix of issue http://code.google.com/p/chromium/issues/detail?id=3285. A NPObject can be called as a construct if it implements NPN_Construct, and NOT implements NPN_InvokeDefault. Otherwise, NPN_InvokeDefault is called even when the object is called as a constructor. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=15029

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -1 line)			Patch
	M	webkit/port/bindings/v8/V8NPObject.cpp	View		2 chunks	+12 lines, -1 line	0 comments	Download

Total messages: 2 (0 generated)

LGTM