Issue 56164: The layoutTestController had its queueScript method broken into two:...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 56164: The layoutTestController had its queueScript method broken into two:... (Closed)

Created:
11 years, 8 months ago by darin (slow to review)

Modified:
9 years, 7 months ago

Reviewers:
dglazkov

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

The layoutTestController had its queueScript method broken into two: queueLoadingScript and queueNonLoadingScript. The behavior of the work queue also changed to be a bit simpler. Now, each WorkItem reports whether or not it kicked off a load. There is a bit more work to do here to determine if work items actually resulted in a load. For now, I am just guessing, which is almost always correct. I will follow-up with the other part of the CL once this one clears the bots. This change corresponds roughly to: http://trac.webkit.org/changeset/42082 BUG=9581 R=dglazkov Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=12991

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+50 lines, -17 lines)			Patch
	M	webkit/tools/test_shell/layout_test_controller.h	View		2 chunks	+5 lines, -2 lines	0 comments	Download
	M	webkit/tools/test_shell/layout_test_controller.cc	View	1	7 chunks	+45 lines, -15 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM.

Expand Messages | Collapse Messages