Issue 56153: Re-enable save package on linux.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 56153: Re-enable save package on linux. (Closed)

Created:
11 years, 8 months ago by Evan Stade

Modified:
9 years, 6 months ago

Reviewers:
Paul Godavari, brettw

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Re-enable save package on linux, mac. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=12966

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -12 lines)			Patch
M	chrome/browser/download/download_manager.cc	View		2 chunks	+3 lines, -5 lines	0 comments	Download
M	chrome/browser/download/save_package.cc	View	1	4 chunks	+13 lines, -7 lines	0 comments	Download
M	chrome/common/platform_util.h	View		2 chunks	+5 lines, -0 lines	2 comments	Download
M	chrome/common/platform_util_linux.cc	View		2 chunks	+6 lines, -0 lines	0 comments	Download
M	chrome/common/platform_util_mac.mm	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/common/platform_util_win.cc	View		2 chunks	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Evan Stade

I guess it should also work for mac but I haven't tested it beyond the ...

11 years, 8 months ago (2009-04-01 17:06:46 UTC) #1

brettw

11 years, 8 months ago (2009-04-02 16:48:33 UTC) #3

LGTM

http://codereview.chromium.org/56153/diff/1007/12
File chrome/common/platform_util.h (right):

http://codereview.chromium.org/56153/diff/1007/12#newcode18
Line 18: gfx::NativeWindow GetTopLevel(gfx::NativeView view);
How about GetTopLevelNativeView?

http://codereview.chromium.org/56153/diff/1007/12#newcode20
Line 20: }
Can you add "  // namspace platform_util" here?

Expand Messages | Collapse Messages