Issue 56149: DevTools: add support for main resource load tracking.

Issue 56149: DevTools: add support for main resource load tracking. (Closed)

Created:
11 years, 8 months ago by pfeldman

Modified:
9 years, 7 months ago

Reviewers:
yurys

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

DevTools: add support for provisional load tracking. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=13008

Patch Set 6 : '' #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+117 lines, -60 lines)			Patch
M	webkit/glue/devtools/js/devtools.js	View	3 4 5	2 chunks	+7 lines, -2 lines	0 comments	Download
M	webkit/glue/devtools/js/inspector_controller_impl.js	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	webkit/glue/devtools/js/net_agent.js	View	3 4 5	4 chunks	+21 lines, -0 lines	0 comments	Download
M	webkit/glue/devtools/net_agent_impl.h	View	2 3 4 5	1 chunk	+6 lines, -1 line	0 comments	Download
M	webkit/glue/devtools/net_agent_impl.cc	View	1 2 3 4 5	4 chunks	+45 lines, -30 lines	0 comments	Download
M	webkit/glue/webdevtoolsagent_impl.h	View	1 2	2 chunks	+9 lines, -8 lines	0 comments	Download
M	webkit/glue/webdevtoolsagent_impl.cc	View	1 2 3	5 chunks	+27 lines, -18 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

yurys

LG http://codereview.chromium.org/56149/diff/1020/1026 File webkit/glue/devtools/js/devtools.js (right): http://codereview.chromium.org/56149/diff/1020/1026#newcode118 Line 118: * @see tools_agent.h add @params http://codereview.chromium.org/56149/diff/1020/1025 File ...

11 years, 8 months ago (2009-04-02 12:39:02 UTC) #2

pfeldman

11 years, 8 months ago (2009-04-02 14:17:21 UTC) #3

http://codereview.chromium.org/56149/diff/1020/1026
File webkit/glue/devtools/js/devtools.js (right):

http://codereview.chromium.org/56149/diff/1020/1026#newcode118
Line 118: * @see tools_agent.h
On 2009/04/02 12:39:02, Yury Semikhatsky wrote:
> add @params

Done.

http://codereview.chromium.org/56149/diff/1020/1025
File webkit/glue/devtools/js/net_agent.js (right):

http://codereview.chromium.org/56149/diff/1020/1025#newcode30
Line 30: * Rests dom agent to its initial state.
On 2009/04/02 12:39:02, Yury Semikhatsky wrote:
>  Rests ->  Resets

Done.

http://codereview.chromium.org/56149/diff/1020/1025#newcode90
Line 90: debugPrint('willSendRequest ' + identifier + ': ' + resource.url + ' at
'
On 2009/04/02 12:39:02, Yury Semikhatsky wrote:
> remove this line

Done.

http://codereview.chromium.org/56149/diff/1020/1025#newcode122
Line 122: debugPrint('didReceiveResponse ' + identifier + ': ' + resource.url +
' at '
On 2009/04/02 12:39:02, Yury Semikhatsky wrote:
> ditto

Done.

http://codereview.chromium.org/56149/diff/1020/1025#newcode145
Line 145: debugPrint('didFinishLoading ' + identifier + ': ' + resource.url + '
at ' +
On 2009/04/02 12:39:02, Yury Semikhatsky wrote:
> ditto

Done.

http://codereview.chromium.org/56149/diff/1020/1025#newcode162
Line 162: debugPrint('didFailLoading ' + identifier + ': ' + resource.url);
On 2009/04/02 12:39:02, Yury Semikhatsky wrote:
> ditto

Done.

http://codereview.chromium.org/56149/diff/1020/1024
File webkit/glue/devtools/net_agent_impl.cc (right):

http://codereview.chromium.org/56149/diff/1020/1024#newcode84
Line 84: DictionaryValue* resource = pending_resources_.get(identifier);
On 2009/04/02 12:39:02, Yury Semikhatsky wrote:
> please make sure that .get will return 0 when there is no such key in the map

Done.

http://codereview.chromium.org/56149/diff/1020/1024#newcode113
Line 113: DictionaryValue* resource = pending_resources_.get(identifier);
On 2009/04/02 12:39:02, Yury Semikhatsky wrote:
> ditto

Done.

http://codereview.chromium.org/56149/diff/1020/1024#newcode137
Line 137: delete resource;
On 2009/04/02 12:39:02, Yury Semikhatsky wrote:
> You need a map that deletes its value on remove. Consider defining such
> container if you can't find a standard one.
> 

Suggestions on the datatype are welcome :)

http://codereview.chromium.org/56149/diff/1020/1023
File webkit/glue/devtools/net_agent_impl.h (right):

http://codereview.chromium.org/56149/diff/1020/1023#newcode9
Line 9: #include <wtf/OwnPtr.h>
On 2009/04/02 12:39:02, Yury Semikhatsky wrote:
> remove this import, you don't use it

Done.

http://codereview.chromium.org/56149/diff/1020/1023#newcode71
Line 71: void SendMainResource();
On 2009/04/02 12:39:02, Yury Semikhatsky wrote:
> remove this declaration or provide an implementation

Done.

Expand Messages | Collapse Messages