Issue 5614004: Use the PushIfAbsent function for the JSON stringify stack....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5614004: Use the PushIfAbsent function for the JSON stringify stack.... (Closed)

Created:
10 years ago by sandholm

Modified:
9 years, 7 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Use the PushIfAbsent function for the JSON stringify stack. Optimize ConvertToString.

Patch Set 2 : '' #

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -38 lines)			Patch
M	src/array.js	View	1	2 chunks	+15 lines, -18 lines	0 comments	Download
M	src/json.js	View		4 chunks	+4 lines, -18 lines	0 comments	Download
M	src/runtime.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

LGTM http://codereview.chromium.org/5614004/diff/1/src/array.js File src/array.js (right): http://codereview.chromium.org/5614004/diff/1/src/array.js#newcode350 src/array.js:350: return Join(this, TO_UINT32(this.length), ',', ConvertToString); I know this ...

10 years ago (2010-12-08 08:50:20 UTC) #2

sandholm

10 years ago (2010-12-08 09:06:23 UTC) #3

http://codereview.chromium.org/5614004/diff/1/src/array.js
File src/array.js (right):

http://codereview.chromium.org/5614004/diff/1/src/array.js#newcode350
src/array.js:350: return Join(this, TO_UINT32(this.length), ',',
ConvertToString);
On 2010/12/08 08:50:20, Erik Corry wrote:
> I know this is what the spec says, but how can this make a difference?  We
> already checked it was an array.

You are right. I'll take it out again.

Expand Messages | Collapse Messages

Issue 5614004: Use the PushIfAbsent function for the JSON stringify stack.... (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages