Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 5614003: Avoid recursive DisplayDebugMessageInDialog call when an assert is hit on the IO thread (Closed)

Created:
10 years ago by joth
Modified:
9 years, 7 months ago
Reviewers:
Evan Martin
CC:
chromium-reviews, pam+watch_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Avoid recursive DisplayDebugMessageInDialog call when an assert is hit on the IO thread BUG=None TEST=Hacked code to call NOTREACHED() from IO thread. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68468

Patch Set 1 #

Patch Set 2 : Fixup comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M base/logging.cc View 1 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
joth
10 years ago (2010-12-06 17:03:01 UTC) #1
Evan Martin
10 years ago (2010-12-06 18:11:25 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698