Client-based geolocation support.

chrome/browser/geolocation/geolocation_dispatcher_host_old.cc

Index: chrome/browser/geolocation/geolocation_dispatcher_host_old.cc
diff --git a/chrome/browser/geolocation/geolocation_dispatcher_host_old.cc b/chrome/browser/geolocation/geolocation_dispatcher_host_old.cc
index 0af76e046adad9518675e63caa262df50ab412bb..838fe6007024a89b12ce9090e1dc624bf8214bb3 100644
--- a/chrome/browser/geolocation/geolocation_dispatcher_host_old.cc
+++ b/chrome/browser/geolocation/geolocation_dispatcher_host_old.cc
@@ -171,6 +171,9 @@ void GeolocationDispatcherHostOldImpl::OnStartUpdating(
     int bridge_id,
     const GURL& requesting_frame,
     bool enable_high_accuracy) {
+#if defined(ENABLE_CLIENT_BASED_GEOLOCATION)

[joth, 2010/12/07 10:24:51]

just to check, in the gypi you have set ENABLE_CLIENT_BASED_GEOLOCATION=0. Does
this not mean defined(ENABLE_CLIENT_BASED_GEOLOCATION) will be true?

[John Knottenbelt, 2010/12/07 12:30:04]

No, see comments in chrome_browser.gypi

+  OnRegisterDispatcher(render_view_id);
+#endif
   // WebKit sends the startupdating request before checking permissions, to
   // optimize the no-location-available case and reduce latency in the success
   // case (location lookup happens in parallel with the permission request).
@@ -194,6 +197,9 @@ void GeolocationDispatcherHostOldImpl::OnStopUpdating(int render_view_id,
     RefreshGeolocationObserverOptions();
   geolocation_permission_context_->StopUpdatingRequested(
       resource_message_filter_process_id_, render_view_id, bridge_id);
+#if defined(ENABLE_CLIENT_BASED_GEOLOCATION)
+  OnUnregisterDispatcher(render_view_id);
+#endif
 }
 
 void GeolocationDispatcherHostOldImpl::OnSuspend(int render_view_id,