Client-based geolocation support.

chrome/renderer/geolocation_dispatcher.h

+// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.

[bulach, 2010/12/07 11:18:42]

\n

+#ifndef CHROME_RENDERER_GEOLOCATION_DISPATCHER_H_
+#define CHROME_RENDERER_GEOLOCATION_DISPATCHER_H_
+#pragma once
+
+#if defined(ENABLE_CLIENT_BASED_GEOLOCATION)
+
+#include "third_party/WebKit/WebKit/chromium/public/WebGeolocationClient.h"
+#include "third_party/WebKit/WebKit/chromium/public/WebGeolocationController.h"
+#include "base/scoped_ptr.h"

[joth, 2010/12/07 10:24:51]

base before third_party

+
+class RenderView;
+struct Geoposition;
+
+namespace WebKit {
+class WebGeolocationPermissionRequest;
+class WebGeolocationPermissionRequestContainer;
+class WebGeolocationPosition;
+class WebSecurityOrigin;
+class WebGeolocationController;

[joth, 2010/12/07 10:24:51]

alpha order

+}
+
+namespace IPC {
+class Message;
+};

[joth, 2010/12/07 10:24:51]

nit: no ;

+
+// GeolocationDispatcher is a delegate for Geolocation messages used by
+// WebKit.
+// It's the complement of GeolocationDispatcherOld (owned by RenderViewHost).

[joth, 2010/12/07 10:24:51]

isn't this the complement of GeolocationDispatcherHost? It's the replacement for
GeolocationDispatcherOld

[joth, 2010/12/08 10:47:40]

ping

[John Knottenbelt, 2010/12/08 12:28:34]

Done.

+

[joth, 2010/12/07 10:24:51]

nit: remove \n

+class GeolocationDispatcher : public WebKit::WebGeolocationClient {
+ public:
+  explicit GeolocationDispatcher(RenderView*);

[joth, 2010/12/07 10:24:51]

In chrome we do put the parameter names in method declarations. (not sure about
in the implementations of the WebKit methods below, but my instinct would be to
include them all)

+  virtual ~GeolocationDispatcher();
+
+  // IPC
+  bool OnMessageReceived(const IPC::Message&);
+
+  // WebGeolocationClient
+  virtual void geolocationDestroyed();
+  virtual void startUpdating();
+  virtual void stopUpdating();
+  virtual void setEnableHighAccuracy(bool);
+  virtual void setController(const WebKit::WebGeolocationController&);
+  virtual bool lastPosition(WebKit::WebGeolocationPosition&);
+  virtual void requestPermission(
+      const WebKit::WebGeolocationPermissionRequest&);
+  virtual void cancelPermissionRequest(
+      const WebKit::WebGeolocationPermissionRequest&);
+
+ private:
+  RenderView* render_view_;

[joth, 2010/12/07 10:24:51]

comment ownership

[joth, 2010/12/08 10:47:40]

ping

+  WebKit::WebGeolocationController controller_;
+
+  // Permission for using geolocation has been set.
+  void OnGeolocationPermissionSet(int bridge_id, bool is_allowed);
+
+  // We have an updated geolocation position or error code.
+  void OnGeolocationPositionUpdated(const Geoposition& geoposition);

[joth, 2010/12/07 10:24:51]

put all methods before member data within each section.

+
+  scoped_ptr<WebKit::WebGeolocationPermissionRequestContainer>
+      pending_permissions_;
+  bool enable_high_accuracy_;
+  bool updating_;
+};
+
+#endif // ENABLE_CLIENT_BASED_GEOLOCATION

[bulach, 2010/12/07 11:18:42]

\n

+#endif // CHROME_RENDERER_GEOLOCATION_DISPATCHER_H_