Client-based geolocation support.

chrome/chrome_browser.gypi

 # Copyright (c) 2010 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'targets': [
     {
       'target_name': 'browser',
       'type': '<(library)',
       'msvs_guid': '5BF908A7-68FB-4A4B-99E3-8C749F1FE4EA',
@@ skipping 4256 matching lines @@
             'browser/importer/ie_importer.cc',
           ],
         }],
         [ 'use_openssl==1', {
           'sources!': [
             'browser/importer/nss_decryptor.cc',
             'browser/importer/nss_decryptor_system_nss.cc',
             'browser/importer/nss_decryptor_system_nss.h',
           ],
         }],
+        ['"ENABLE_CLIENT_BASED_GEOLOCATION=1" in feature_defines', {

[joth, 2010/12/07 10:24:51]

this looks unusual, not least because it is = rather than == like the other
conditions.
Maybe put a comment on this saying it's an transitory thing whilst bug X is in
progress and it will be removed real soon.

The other option is to unconditionally set the ENABLE_CLIENT_BASED_GEOLOCATION
define here, and have a comment saying it should be kept in sync with the value
in feature defines.

[John Knottenbelt, 2010/12/07 12:30:04]

I'll add a comment in to say that it will disappear once we have completed a
migration to client-based geolocation (together with some bug references).

The defines in feature_override.gypi are only automatically exposed as
preprocessor macros when compiling the WebKit source. The above exposes
ENABLE_CLIENT_BASED_GEOLOCATION as a preprocessor macro when compiling Chromium
code.

+          'defines': [ 'ENABLE_CLIENT_BASED_GEOLOCATION=1' ]

[joth, 2010/12/07 10:24:51]

ah, I see that explains it, this is a different ENABLE_CLIENT_BASED_GEOLOCATION
macro to the feature_defines one.
As they carry different values ([0,1] vs [undefined,1]) maybe give them
different names?

[John Knottenbelt, 2010/12/07 12:30:04]

The feature_defines array is purely a gyp variable. In WebKit, these are exposed
as ENABLE_XXX if ENABLE_XXX=1 is present in the features_defines and undefined
otherwise, which is why I have adopted the same practice on this end.

+        }],
       ],
     },
     {
       # Protobuf compiler / generate rule for feedback
       'target_name': 'userfeedback_proto',
       'type': 'none',
       'sources': [
         'browser/userfeedback/proto/annotations.proto',
         'browser/userfeedback/proto/chrome.proto',
         'browser/userfeedback/proto/common.proto',
@@ skipping 88 matching lines @@
       ],
     },
   ],
 }
 
 # Local Variables:
 # tab-width:2
 # indent-tabs-mode:nil
 # End:
 # vim: set expandtab tabstop=2 shiftwidth=2: