Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 56107: * Add rmdir, mkdir -p and umask to d8 on Unix.... (Closed)

Created:
11 years, 8 months ago by Erik Corry
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

* Add rmdir, mkdir -p and umask to d8 on Unix. * Remove the non-working methods from the os object on d8 on Windows so you can test for their presence with if (os.system). * Add a test (not run by default since it only works on d8). * Fix incorrect use of wait that left defunct processes (zombies). Committed: http://code.google.com/p/v8/source/detail?r=1650 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56276

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+300 lines, -18 lines) Patch
M src/d8.h View 1 chunk +12 lines, -0 lines 0 comments Download
M src/d8.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/d8-posix.cc View 6 chunks +108 lines, -3 lines 2 comments Download
M src/d8-windows.cc View 1 chunk +2 lines, -12 lines 2 comments Download
A test/mjsunit/d8-os.js View 1 chunk +177 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Erik Corry
11 years, 8 months ago (2009-03-31 12:13:23 UTC) #1
Søren Thygesen Gjesse
http://codereview.chromium.org/56107/diff/1/5 File src/d8-posix.cc (right): http://codereview.chromium.org/56107/diff/1/5#newcode587 Line 587: if (errno == EEXIST) { Is this is ...
11 years, 8 months ago (2009-03-31 12:28:01 UTC) #2
Erik Corry
11 years, 8 months ago (2009-03-31 12:36:30 UTC) #3
http://codereview.chromium.org/56107/diff/1/5
File src/d8-posix.cc (right):

http://codereview.chromium.org/56107/diff/1/5#newcode587
Line 587: if (errno == EEXIST) {
On 2009/03/31 12:28:02, Søren Gjesse wrote:
> Is this is to handle from paths with '..' e.g. xxx/yyy/../yyy, or is it not
> supposed to happen?

Can I just pretend that's what I was thinking about all along?

Test added to ensure that it actually works this way.

http://codereview.chromium.org/56107/diff/1/3
File src/d8-windows.cc (right):

http://codereview.chromium.org/56107/diff/1/3#newcode39
Line 39: os_templ->Set(String::New("setenv"),
FunctionTemplate::New(SetEnvironment));
On 2009/03/31 12:28:02, Søren Gjesse wrote:
> Why did you leave setenv here? It is not implemented either.

Good point.  Removed.

Powered by Google App Engine
This is Rietveld 408576698