Keep the result of postfix increment and decrement in a register.

Keep the result of postfix increment and decrement in a register.

Committed: http://code.google.com/p/v8/source/detail?r=1656

[William Hesse, 2009-03-31 12:04:04]

A petty code review for you to look at sometime.

[Kevin Millikin (Chromium), 2009-03-31 13:22:23]

http://codereview.chromium.org/56106/diff/1/2
File src/codegen-ia32.cc (right):

http://codereview.chromium.org/56106/diff/1/2#newcode4807
Line 4807: Result old_value = allocator_->Allocate();
As we discussed, it might be better to be less eager about moving value into a
register.  If it is a constant in the postfix case, there is no need to use up
another register to put it back in the frame.

[William Hesse, 2009-03-31 13:35:04]

Change made and tested.

http://codereview.chromium.org/56106/diff/1/2
File src/codegen-ia32.cc (right):

http://codereview.chromium.org/56106/diff/1/2#newcode4807
Line 4807: Result old_value = allocator_->Allocate();
On 2009/03/31 13:22:23, Kevin Millikin wrote:
> As we discussed, it might be better to be less eager about moving value into a
> register.  If it is a constant in the postfix case, there is no need to use up
> another register to put it back in the frame.

Done.

[Kevin Millikin (Chromium), 2009-03-31 14:13:34]

LGTM.