Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 56105: Reland exception propagation fix.... (Closed)

Created:
11 years, 8 months ago by Mads Ager (chromium)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Reland exception propagation fix. Fix exception propagation problem where undefined was returned instead of an empty handle in case of an exception. This problem can break C++ programs that are not interested in catching exceptions and just want to propagate them out by testing for empty handles. The issue is that exceptions are not rescheduled if they are externally caught. Externally caught exceptions have to be rescheduled if there is a JavaScript frame on the way to the C++ frame that holds the external handler. A couple of tests will fail on the ARM simulator because the simulator has separate stacks for C++ and JavaScript. I have marked the tests as failing only on the simulator. Committed: http://code.google.com/p/v8/source/detail?r=1657

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -19 lines) Patch
M src/top.h View 2 chunks +2 lines, -3 lines 0 comments Download
M src/top.cc View 3 chunks +31 lines, -11 lines 0 comments Download
M test/cctest/cctest.status View 1 chunk +8 lines, -0 lines 0 comments Download
M test/cctest/test-api.cc View 6 chunks +18 lines, -4 lines 0 comments Download
M tools/test.py View 1 chunk +2 lines, -1 line 1 comment Download

Messages

Total messages: 2 (0 generated)
Mads Ager (chromium)
11 years, 8 months ago (2009-03-31 12:01:35 UTC) #1
Søren Thygesen Gjesse
11 years, 8 months ago (2009-03-31 12:58:33 UTC) #2
LGTM

http://codereview.chromium.org/56105/diff/1/4
File tools/test.py (right):

http://codereview.chromium.org/56105/diff/1/4#newcode1265
Line 1265: 'simulator': options.simulator
Is this to "replace" -S simulator=arm?

Powered by Google App Engine
This is Rietveld 408576698