Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2115)

Unified Diff: chrome/browser/cocoa/cookie_tree_node.h

Issue 561023: Merge 37695 - [Mac] Reduce jank in the cookie manager by lazily creating chil... (Closed) Base URL: svn://svn.chromium.org/chrome/branches/307/src/
Patch Set: Created 10 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/cocoa/cookie_tree_node.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/cocoa/cookie_tree_node.h
===================================================================
--- chrome/browser/cocoa/cookie_tree_node.h (revision 37852)
+++ chrome/browser/cocoa/cookie_tree_node.h (working copy)
@@ -12,6 +12,8 @@
@interface CocoaCookieTreeNode : NSObject {
scoped_nsobject<NSString> title_;
scoped_nsobject<NSMutableArray> children_;
+ // We lazily create children, so we need to know if we are a leaf.
+ BOOL isLeaf_;
// The platform-independent model node.
CookieTreeNode* treeNode_; // weak
@@ -39,7 +41,7 @@
// Getters.
- (NSString*)title;
// |-children| is mutable so that the CookiesTreeModelObserverBridge can
-// operate on the children.
+// operate on the children. Note that this lazily creates children.
- (NSMutableArray*)children;
- (TreeModelNode*)treeNode;
« no previous file with comments | « no previous file | chrome/browser/cocoa/cookie_tree_node.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698