Issue 5610002: Don't re-save autofill profiles to the web database if they haven't changed.

Issue 5610002: Don't re-save autofill profiles to the web database if they haven't changed. (Closed)

Created:
10 years ago by Ilya Sherman

Modified:
9 years, 7 months ago

Reviewers:
dhollowa

CC:
chromium-reviews, Paweł Hajdan Jr., ben+cc_chromium.org, dhollowa

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Don't re-save autofill profiles to the web database if they haven't changed. BUG=65129 TEST=unit_tests --gtest_filter=WebDatabaseTest.Update* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68358

Patch Set 1 #

Patch Set 2 : Compile. #

Total comments: 4

Patch Set 3 : Denitting #

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+180 lines, -0 lines)			Patch
M	chrome/browser/webdata/web_database.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/webdata/web_database.cc	View	1 2	2 chunks	+16 lines, -0 lines	0 comments	Download
M	chrome/browser/webdata/web_database_unittest.cc	View	1	1 chunk	+162 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

dhollowa

http://codereview.chromium.org/5610002/diff/3001/chrome/browser/webdata/web_database.cc File chrome/browser/webdata/web_database.cc (right): http://codereview.chromium.org/5610002/diff/3001/chrome/browser/webdata/web_database.cc#newcode1698 chrome/browser/webdata/web_database.cc:1698: AutoFillProfile* tmp_profile; Please initialize this to NULL. If the ...

10 years ago (2010-12-03 16:02:21 UTC) #2

Ilya Sherman

10 years ago (2010-12-04 01:47:12 UTC) #3

LGTM.

Expand Messages | Collapse Messages