cupsGetPPD got stuck sometime for an infinite time due to network configurati...

cupsGetPPD got stuck sometime for an infinite time due to network configuration/issues.
Make http connection for cupsGetPPD non-blocking to prevent that.

BUG=none
TEST=Make sure GettPPD does not get stuck.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68356

[sanjeevr, 2010-12-03 23:46:37]

http://codereview.chromium.org/5609004/diff/1/printing/backend/cups_helper.h
File printing/backend/cups_helper.h (right):

http://codereview.chromium.org/5609004/diff/1/printing/backend/cups_helper.h#...
printing/backend/cups_helper.h:23: void SetBlocking(bool blocking);
Possible to unit-test this?

http://codereview.chromium.org/5609004/diff/1/printing/backend/print_backend_...
File printing/backend/print_backend_cups.cc (right):

http://codereview.chromium.org/5609004/diff/1/printing/backend/print_backend_...
printing/backend/print_backend_cups.cc:224: // cupsGetPPD2 got stuck sometimes
for an infinite time due to network
got => gets
Also "for an infinite loop" => "in an infinite loop"

http://codereview.chromium.org/5609004/diff/1/printing/backend/print_backend_...
printing/backend/print_backend_cups.cc:228: // connection will timeout after 10
secons of no data period. And it will
secons => seconds

http://codereview.chromium.org/5609004/diff/1/printing/backend/print_backend_...
printing/backend/print_backend_cups.cc:242: content_len > ppd_size) {
content_len != ppd_size ?

[sanjeevr, 2010-12-04 00:00:18]

LGTM as per our discussion. Please fix the comments and add a comment about the
content_length check.

[gene1, 2010-12-04 00:07:06]

Done and uploaded. Feel free to take a look.

On Fri, Dec 3, 2010 at 4:00 PM, <sanjeevr@chromium.org> wrote:

> LGTM as per our discussion. Please fix the comments and add a comment about
> the
> content_length check.
>
>
> http://codereview.chromium.org/5609004/
>