Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 5608003: Add a disabled property to DOMUI lists (Closed)

Created:
10 years ago by stuartmorgan
Modified:
9 years, 7 months ago
CC:
chromium-reviews, arv (Not doing code reviews), ben+cc_chromium.org
Visibility:
Public.

Description

Add a disabled property to DOMUI lists Also restricts the extra highlighting of options page list element to just the lead element, since that code was changing anyway to handle disabling. BUG=60838 TEST=Startup page list in DOMUI options should look and act disable when the corresponding option is not selected. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68389

Patch Set 1 #

Total comments: 6

Patch Set 2 : Use a property #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -3 lines) Patch
M chrome/browser/resources/options/browser_options.js View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/options/options_page.css View 1 2 chunks +16 lines, -2 lines 0 comments Download
M chrome/browser/resources/shared/css/list.css View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/shared/js/cr/ui/list.js View 1 3 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
stuartmorgan
10 years ago (2010-12-04 00:09:21 UTC) #1
arv (Not doing code reviews)
http://codereview.chromium.org/5608003/diff/1/chrome/browser/resources/options/options_page.css File chrome/browser/resources/options/options_page.css (right): http://codereview.chromium.org/5608003/diff/1/chrome/browser/resources/options/options_page.css#newcode370 chrome/browser/resources/options/options_page.css:370: list.disabled > [lead][selected], Use disabled attribute http://codereview.chromium.org/5608003/diff/1/chrome/browser/resources/shared/js/cr/ui/list.js File chrome/browser/resources/shared/js/cr/ui/list.js ...
10 years ago (2010-12-04 01:03:27 UTC) #2
stuartmorgan
http://codereview.chromium.org/5608003/diff/1/chrome/browser/resources/options/options_page.css File chrome/browser/resources/options/options_page.css (right): http://codereview.chromium.org/5608003/diff/1/chrome/browser/resources/options/options_page.css#newcode370 chrome/browser/resources/options/options_page.css:370: list.disabled > [lead][selected], On 2010/12/04 01:03:27, arv wrote: > ...
10 years ago (2010-12-04 01:36:51 UTC) #3
arv (Not doing code reviews)
10 years ago (2010-12-06 21:31:44 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698