Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 5608001: Make max len parametrable so it can be modified for users. (Closed)

Created:
10 years ago by M-A Ruel
Modified:
9 years, 7 months ago
Reviewers:
jam
CC:
chromium-reviews, M-A Ruel
Visibility:
Public.

Description

Make max len parametrable so it can be modified for users. Mostly useful for commit-queue as I want to both send the trace and be able to read it locally. TBR=jam Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68055

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M breakpad.py View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
M-A Ruel
10 years ago (2010-12-02 20:20:03 UTC) #1
jam
10 years ago (2010-12-02 20:30:06 UTC) #2
lgtm

On Thu, Dec 2, 2010 at 12:20 PM, <maruel@chromium.org> wrote:

> Reviewers: John Abd-El-Malek,
>
> Description:
> Make max len parametrable so it can be modified for users.
>
> Mostly useful for commit-queue as I want to both send the trace and be able
> to
> read it locally.
>
> TBR=jam
>
> Please review this at http://codereview.chromium.org/5608001/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
>
> Affected files:
>  M breakpad.py
>
>
> Index: breakpad.py
> diff --git a/breakpad.py b/breakpad.py
> index
>
a4539cbb72130a1129985e2cff7c771f21b2f9aa..d5b4d926a0af6da64febd81d905fe126e04a2618
> 100644
> --- a/breakpad.py
> +++ b/breakpad.py
> @@ -55,7 +55,7 @@ def FormatException(e):
>   return out
>
>
> -def SendStack(last_tb, stack, url=None):
> +def SendStack(last_tb, stack, url=None, maxlen=50):
>   """Sends the stack trace to the breakpad server."""
>   if not url:
>     url = DEFAULT_URL
> @@ -71,7 +71,8 @@ def SendStack(last_tb, stack, url=None):
>         'version': sys.version,
>     }
>     # pylint: disable=W0702
> -    print('\n'.join('  %s: %s' % (k, v[0:50]) for k, v in
> params.iteritems()))
> +    print('\n'.join('  %s: %s' % (k, v[0:maxlen])
> +                    for k, v in params.iteritems()))
>     request = urllib.urlopen(url, urllib.urlencode(params))
>     print(request.read())
>     request.close()
>
>
>

Powered by Google App Engine
This is Rietveld 408576698