Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 5607004: net: Remove typedef net::URLRequestJob URLRequestJob; (Closed)

Created:
10 years ago by tfarina
Modified:
9 years, 7 months ago
CC:
chromium-reviews, michaeln, cbentzel+watch_chromium.org, nkostylev+cc_chromium.org, ben+cc_chromium.org, Erik does not do reviews, brettw-cc_chromium.org, Aaron Boodman, pam+watch_chromium.org, Paweł Hajdan Jr., darin-cc_chromium.org, amit, davemoore+watch_chromium.org, ceee-reviews_chromium.org
Visibility:
Public.

Description

net: Remove typedef net::URLRequestJob URLRequestJob; BUG=64263 TEST=compiled locally, trybots Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68935

Patch Set 1 #

Patch Set 2 : rebased #

Total comments: 2

Patch Set 3 : rebased 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+231 lines, -220 lines) Patch
M chrome/browser/appcache/view_appcache_internals_job_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/automation/url_request_automation_job.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/automation/url_request_automation_job.cc View 4 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/chrome_plugin_host.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/gview_request_interceptor.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/gview_request_interceptor.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/gview_request_interceptor_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/account_screen_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/registration_screen.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/dom_ui/chrome_url_data_manager.cc View 1 2 5 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/dom_ui/mediaplayer_ui.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/dom_ui/mediaplayer_ui.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/autoupdate_interceptor.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_protocols.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/extensions/user_script_listener_unittest.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/net/blob_url_request_job_factory.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/net/metadata_url_request.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/net/url_request_failed_dns_job.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/net/url_request_mock_http_job.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/net/url_request_mock_http_job.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/net/url_request_mock_link_doctor_job.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/url_request_mock_link_doctor_job.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/net/url_request_mock_net_error_job.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/url_request_mock_net_error_job.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/net/url_request_slow_download_job.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/net/url_request_slow_download_job.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/net/url_request_slow_http_job.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/net/view_blob_internals_job_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/view_http_cache_job_factory.cc View 4 chunks +7 lines, -4 lines 0 comments Download
M chrome/browser/policy/device_management_service_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/print_dialog_cloud_uitest.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/renderer_host/resource_dispatcher_host_request_info.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/resource_dispatcher_host_unittest.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/renderer_host/resource_queue_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/task_manager/task_manager.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/common/net/url_request_intercept_job.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/net/url_request_intercept_job.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome_frame/test/net/test_automation_provider.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M net/base/net_log_event_type_list.h View 1 chunk +2 lines, -2 lines 0 comments Download
M net/url_request/url_request_about_job.h View 1 chunk +1 line, -1 line 0 comments Download
M net/url_request/url_request_about_job.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M net/url_request/url_request_data_job.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/url_request/url_request_error_job.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/url_request/url_request_error_job.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/url_request/url_request_file_dir_job.h View 1 chunk +2 lines, -2 lines 0 comments Download
M net/url_request/url_request_file_dir_job.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/url_request/url_request_file_job.h View 1 chunk +1 line, -1 line 0 comments Download
M net/url_request/url_request_file_job.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M net/url_request/url_request_ftp_job.h View 1 chunk +6 lines, -6 lines 0 comments Download
M net/url_request/url_request_ftp_job.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M net/url_request/url_request_http_job.h View 2 chunks +6 lines, -6 lines 0 comments Download
M net/url_request/url_request_http_job.cc View 1 2 4 chunks +5 lines, -5 lines 0 comments Download
M net/url_request/url_request_job.h View 1 chunk +0 lines, -2 lines 0 comments Download
M net/url_request/url_request_job.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/url_request/url_request_job_manager.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M net/url_request/url_request_job_manager.cc View 1 2 7 chunks +9 lines, -8 lines 0 comments Download
M net/url_request/url_request_job_metrics.h View 1 chunk +1 line, -1 line 0 comments Download
M net/url_request/url_request_job_tracker.cc View 2 chunks +8 lines, -8 lines 0 comments Download
M net/url_request/url_request_job_tracker_unittest.cc View 3 chunks +13 lines, -12 lines 0 comments Download
M net/url_request/url_request_redirect_job.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M net/url_request/url_request_redirect_job.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M net/url_request/url_request_simple_job.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/url_request/url_request_test_job.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M net/url_request/url_request_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M webkit/appcache/appcache_interceptor.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M webkit/appcache/appcache_request_handler_unittest.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M webkit/appcache/appcache_update_job_unittest.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M webkit/appcache/appcache_url_request_job.h View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M webkit/appcache/appcache_url_request_job.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M webkit/appcache/appcache_url_request_job_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M webkit/appcache/view_appcache_internals_job.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/blob/blob_url_request_job.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webkit/blob/blob_url_request_job.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/blob/blob_url_request_job_unittest.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M webkit/tools/test_shell/simple_resource_loader_bridge.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/tools/test_shell/test_shell.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
tfarina
Please, take a look.
10 years ago (2010-12-04 03:52:17 UTC) #1
willchan no longer on Chromium
rubber stamp LGTM
10 years ago (2010-12-06 20:01:52 UTC) #2
wtc
10 years ago (2010-12-08 19:32:48 UTC) #3
I only reviewed your changes to the 'net' directory.
Please do not hold your checkin for my reviews.

http://codereview.chromium.org/5607004/diff/3001/net/base/net_log_event_type_...
File net/base/net_log_event_type_list.h (right):

http://codereview.chromium.org/5607004/diff/3001/net/base/net_log_event_type_...
net/base/net_log_event_type_list.h:468: // net::URLRequest
Inside the 'net' directory, the 'net::' prefix should be
omitted for brevity whenever possible.

For example, on lines 498, 519, etc. below, we do not use
the net:: prefix for the HttpCache, HttpNetworkTransaction,
etc. types that are in the net namespace.

http://codereview.chromium.org/5607004/diff/3001/net/url_request/url_request_...
File net/url_request/url_request_about_job.h (right):

http://codereview.chromium.org/5607004/diff/3001/net/url_request/url_request_...
net/url_request/url_request_about_job.h:14: class URLRequestAboutJob : public
net::URLRequestJob {
We should move these URLRequestXXXJobs into the 'net' namespace
in the future.

Powered by Google App Engine
This is Rietveld 408576698