Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issue 5607001: Removed kChromiumRendererIdProperty window property.... (Closed)

Created:
10 years ago by apatrick_chromium
Modified:
9 years, 7 months ago
CC:
chromium-reviews, ben+cc_chromium.org, darin-cc_chromium.org, apatrick_chromium, brettw-cc_chromium.org
Visibility:
Public.

Description

Removed kChromiumRendererIdProperty window property. This property was used by the GPU process to determine whether a particular renderer process had the right to render to a window. It turns out that this is no longer needed because now the browser tells the GPU process which child compositor window to render to and the GPU process trusts the browser process. Also uncovered and fixed a bug in gpu_channel_host.cc where the renderer would hang if the GPU process failed to return a command buffer. TEST=try BUG=64834 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68096

Patch Set 1 : '' #

Total comments: 1

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -47 lines) Patch
M chrome/browser/renderer_host/render_widget_host_view_win.h View 1 3 chunks +2 lines, -8 lines 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view_win.cc View 1 4 chunks +2 lines, -12 lines 0 comments Download
M chrome/common/chrome_constants.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/common/chrome_constants.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/gpu/gpu_channel.cc View 2 chunks +12 lines, -15 lines 0 comments Download
M chrome/renderer/gpu_channel_host.cc View 2 chunks +11 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
apatrick_chromium
10 years ago (2010-12-02 20:19:59 UTC) #1
sky
http://codereview.chromium.org/5607001/diff/5001/chrome/browser/renderer_host/render_widget_host_view_win.cc File chrome/browser/renderer_host/render_widget_host_view_win.cc (left): http://codereview.chromium.org/5607001/diff/5001/chrome/browser/renderer_host/render_widget_host_view_win.cc#oldcode317 chrome/browser/renderer_host/render_widget_host_view_win.cc:317: renderer_id_prop_.reset( Remove renderer_id_prop_ from the header,the forward declaration of ...
10 years ago (2010-12-02 20:27:25 UTC) #2
apatrick_chromium
Done.
10 years ago (2010-12-02 21:41:54 UTC) #3
sky
LGTM
10 years ago (2010-12-02 21:48:08 UTC) #4
Ken Russell (switch to Gerrit)
10 years ago (2010-12-02 21:53:13 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld 408576698