Streamline the layout of the BrowserView's children TabContents views....

views/controls/single_split_view.h

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef VIEWS_CONTROLS_SINGLE_SPLIT_VIEW_H_
 #define VIEWS_CONTROLS_SINGLE_SPLIT_VIEW_H_
 #pragma once
 
 #include "views/view.h"
 
 namespace views {
 
-// SingleSplitView lays out two views horizontally. A splitter exists between
-// the two views that the user can drag around to resize the views.
+// SingleSplitView lays out two views next to each other, either horizontally
+// or vertically. A splitter exists between the two views that the user can
+// drag around to resize the views. It does not change these views bounds
+// though, the actual resize is a resonsibility of the entity resizing
+// the SingleSplitView itself. Observer's SplitHandleMoved notification helps
+// to handle user initiated layout changes.

[sky, 2011/01/06 17:55:02]

The Observer should be optional, a NULL observer means layout happens
immediately.

[Aleksey Shlyapnikov, 2011/01/07 19:07:23]

Done.

 class SingleSplitView : public views::View {
  public:
   enum Orientation {
     HORIZONTAL_SPLIT,
     VERTICAL_SPLIT
   };
 
-  SingleSplitView(View* leading, View* trailing, Orientation orientation);
+  class Observer {
+   public:
+    // Invoked when split handle is moved by the user.

[sky, 2011/01/06 17:55:02]

This should return a boolean indicating if Layout should be invoked. BrowserView
would return false.

[Aleksey Shlyapnikov, 2011/01/07 19:07:23]

In the updated version SingleSplitView does layout only when observer is not
provided, otherwise it's a observer responsibility to lay out children views.

On 2011/01/06 17:55:02, sky wrote:

+    virtual void SplitHandleMoved(SingleSplitView* source) = 0;
+   protected:
+    virtual ~Observer() {}
+  };
+
+  SingleSplitView(View* leading, View* trailing, Orientation orientation,
+                  Observer* observer);
 
   virtual void DidChangeBounds(const gfx::Rect& previous,
                                const gfx::Rect& current);
 
   virtual void Layout();
 
   virtual AccessibilityTypes::Role GetAccessibleRole();
 
   // SingleSplitView's preferred size is the sum of the preferred widths
   // and the max of the heights.
   virtual gfx::Size GetPreferredSize();
 
   // Overriden to return a resize cursor when over the divider.
   virtual gfx::NativeCursor GetCursorForPoint(Event::EventType event_type,
                                               const gfx::Point& p);
 
   void set_divider_offset(int divider_offset) {
     divider_offset_ = divider_offset;
   }
   int divider_offset() { return divider_offset_; }
 
   // Sets whether the leading component is resized when the split views size
   // changes. The default is true. A value of false results in the trailing
   // component resizing on a bounds change.
   void set_resize_leading_on_bounds_change(bool resize) {
     resize_leading_on_bounds_change_ = resize;
   }
 
+  const gfx::Rect& leading_view_rect() const { return leading_view_rect_; }
+  const gfx::Rect& trailing_view_rect() const { return trailing_view_rect_; }
+
+  // Resizes leading and trailing views to the current leading_view_rect_ and
+  // trailing_view_rect_ bounds, accordingly.
+  void ResizeViews();
+
  protected:
   virtual bool OnMousePressed(const MouseEvent& event);
   virtual bool OnMouseDragged(const MouseEvent& event);
   virtual void OnMouseReleased(const MouseEvent& event, bool canceled);
 
  private:
   // Returns true if |x| or |y| is over the divider.
   bool IsPointInDivider(const gfx::Point& p);
 
   // Returns width in case of horizontal split and height otherwise.
@@ skipping 16 matching lines @@
   DragInfo drag_info_;
 
   // Orientation of the split view.
   bool is_horizontal_;
 
   // Position of the divider.
   int divider_offset_;
 
   bool resize_leading_on_bounds_change_;
 
+  // Observer to notify about user initiated handle movements. Not own by us.
+  Observer* observer_;
+  // Leading and trailing views bounds calcualted based on the current

[sky, 2011/01/06 17:55:02]

Newline between 108 and 109.

[sky, 2011/01/06 17:55:02]

calcualted - > calculated

[Aleksey Shlyapnikov, 2011/01/07 19:07:23]

Done.

[Aleksey Shlyapnikov, 2011/01/07 19:07:23]

Done.

+  // |divider_offset_|. Not necessarily equal to the actual views bounds,
+  // ResizeViews() brings them in sync.
+  gfx::Rect leading_view_rect_;
+  gfx::Rect trailing_view_rect_;
+
   DISALLOW_COPY_AND_ASSIGN(SingleSplitView);
 };
 
 }  // namespace views
 
 #endif  // VIEWS_CONTROLS_SINGLE_SPLIT_VIEW_H_