Issue 5606005: DCHECK to detect invalid BrokerRpcClient usage.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5606005: DCHECK to detect invalid BrokerRpcClient usage. (Closed)

Created:
10 years ago by Vitaly Buka (NO REVIEWS)

Modified:
9 years, 7 months ago

Reviewers:
Jói

CC:
chromium-reviews, ceee-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

DCHECK to detect invalid BrokerRpcClient usage. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68291

Patch Set 1 #

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	ceee/ie/broker/broker_rpc_client.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jói

10 years ago (2010-12-04 13:56:30 UTC) #2

LGTM

On Fri, Dec 3, 2010 at 11:16 PM,  <vitalybuka@chromium.org> wrote:
> Reviewers: Jói,
>
> Description:
> DCHECK to detect invalid BrokerRpcClient usage.
>
> BUG=none
> TEST=none
>
>
> Please review this at http://codereview.chromium.org/5606005/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     ceee/ie/broker/broker_rpc_client.cc
>
>
> Index: ceee/ie/broker/broker_rpc_client.cc
> ===================================================================
> --- ceee/ie/broker/broker_rpc_client.cc (revision 68235)
> +++ ceee/ie/broker/broker_rpc_client.cc (working copy)
> @@ -166,8 +166,10 @@
>   if (!rpc_function) {
>     RpcDcheck("rpc_function is NULL");
>   }
> -  if (!is_connected())
> +  if (!is_connected()) {
> +    RpcDcheck("BrokerRpcClient is not connected");
>     return RPC_E_FAULT;
> +  }
>   RpcTryExcept {
>     DispatchToFunction(rpc_function, params);
>     return S_OK;
>
>
>

Expand Messages | Collapse Messages