Issue 5605004: Remove NearestNextGapPos. It is not used anymore.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5605004: Remove NearestNextGapPos. It is not used anymore. (Closed)

Created:
10 years ago by Vyacheslav Egorov (Chromium)

Modified:
9 years, 7 months ago

Reviewers:
fschneider

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Remove NearestNextGapPos. It is not used anymore. Remove uses of NearestGapPos in splitting helpers. We can split at any position. Committed: http://code.google.com/p/v8/source/detail?r=5937

Patch Set 1 #

Total comments: 1

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+2 lines, -27 lines)			Patch
M	src/arm/lithium-arm.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/arm/lithium-arm.cc	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	src/ia32/lithium-ia32.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/ia32/lithium-ia32.cc	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	src/lithium-allocator.cc	View	3 chunks	+2 lines, -8 lines	1 comment	Download
M	src/x64/lithium-x64.h	View	1 chunk	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

fschneider

10 years ago (2010-12-07 14:47:08 UTC) #2

LGTM.

http://codereview.chromium.org/5605004/diff/1/src/lithium-allocator.cc
File src/lithium-allocator.cc (right):

http://codereview.chromium.org/5605004/diff/1/src/lithium-allocator.cc#newcod...
src/lithium-allocator.cc:1789: LifetimePosition pos = free_pos[max_reg];
Fix the comment above.

Expand Messages | Collapse Messages