Issue 56045: A patch for bug 7871

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 56045: A patch for bug 7871 (Closed)

Created:
11 years, 9 months ago by Paul Robinson

Modified:
9 years, 7 months ago

Reviewers:
brettw, Evan Stade

CC:
chromium-reviews_googlegroups.com

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Description

This is a patch for bug 7871. This is a change to BackForwardMenuModel::GetItemLabel to use NavigationEntry::GetTitleForDisplay rather than NavigationEntry::title. For File NavigationEntries the title is stored in the cached_display_title rather than the title. BUG=7871

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	chrome/browser/back_forward_menu_model.cc	View	1	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Evan Stade

Thanks for the patch. http://codereview.chromium.org/56045/diff/1/2 File chrome/browser/back_forward_menu_model.cc (right): http://codereview.chromium.org/56045/diff/1/2#newcode225 Line 225: return UTF16ToWideHack(entry->GetTitleForDisplay(NULL)); you need ...

11 years, 8 months ago (2009-03-30 07:18:06 UTC) #1

Paul Robinson

Added the NavigationController into the call to GetTitleForDisplay

11 years, 8 months ago (2009-03-30 17:58:57 UTC) #2

committed in r12819

Expand Messages | Collapse Messages