Issue 5603009: Update Chrome Search sample extension to utilize

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5603009: Update Chrome Search sample extension to utilize (Closed)

Created:
10 years ago by Aaron Boodman

Modified:
9 years, 6 months ago

Reviewers:
Matt Perry

CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Update Chrome Search sample extension to utilize http://codereview.chromium.org/5607003/. Also, random other polish in the extension. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68448

Patch Set 1 #

Patch Set 2 : whoops #

Patch Set 3 : cleanup #

Total comments: 1

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -21 lines)			Patch
	M	chrome/common/extensions/docs/examples/extensions/chrome_search/background.html	View	1 2	3 chunks	+23 lines, -21 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Matt Perry

10 years ago (2010-12-06 23:10:57 UTC) #2

lgtm

http://codereview.chromium.org/5603009/diff/4001/chrome/common/extensions/doc...
File
chrome/common/extensions/docs/examples/extensions/chrome_search/background.html
(right):

http://codereview.chromium.org/5603009/diff/4001/chrome/common/extensions/doc...
chrome/common/extensions/docs/examples/extensions/chrome_search/background.html:53:
content = content.replace(/<(\/)?b>/g, '<$1match>');
$1match.. clever!

Expand Messages | Collapse Messages