Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 5603008: Modify the "dangerous download" algorithm as follows. Original patch by Pier... (Closed)

Created:
10 years ago by Peter Kasting
Modified:
9 years, 7 months ago
Reviewers:
pierre.lafayette
CC:
chromium-reviews, ben+cc_chromium.org, Erik does not do reviews, brettw-cc_chromium.org, Aaron Boodman, pam+watch_chromium.org, rdsmith+dwatch_chromium.org, Paweł Hajdan Jr., darin-cc_chromium.org
Visibility:
Public.

Description

Modify the "dangerous download" algorithm as follows. Original patch by Pierre-Antoine LaFayette (see http://codereview.chromium.org/1403001/ ), r=me,brettw,aa. Downloads are considered dangerous if: a) The file is dangerous just by sitting on the drive, without needing to be clicked on e.g. dll, xbap b) The file is executable and the download was not user initiated. c) They are an extension that is not from the gallery We have defined a user initiated download as 3 possible cases: a) A user enters a URL into the address bar that is a file b) A user left clicks on a URL that is a file c) A user right clicks and does "Save As" on a URL that is a file. BUG=9044 TEST=Open a page with a download link to a dangerous file that is not an extension, e.g. an .exe file, and left click on the link. The download should proceed without a prompt. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68406

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+359 lines, -275 lines) Patch
D chrome/browser/download/download_exe.cc View 1 chunk +0 lines, -241 lines 0 comments Download
A chrome/browser/download/download_extensions.h View 1 chunk +39 lines, -0 lines 0 comments Download
A chrome/browser/download/download_extensions.cc View 1 chunk +258 lines, -0 lines 0 comments Download
M chrome/browser/download/download_item.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/download/download_manager.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/download/download_prefs.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/download/download_util.h View 1 chunk +0 lines, -11 lines 0 comments Download
M chrome/browser/download/download_util.cc View 2 chunks +9 lines, -4 lines 0 comments Download
M chrome/browser/extensions/user_script_listener_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/download_create_info.h View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/history/download_create_info.cc View 3 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/history/history_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/download_resource_handler.cc View 3 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/renderer_host/resource_dispatcher_host.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/renderer_host/resource_dispatcher_host_request_info.h View 3 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/renderer_host/resource_dispatcher_host_request_info.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/renderer_host/resource_dispatcher_host_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/resource_queue_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/common/navigation_gesture.h View 1 chunk +2 lines, -6 lines 0 comments Download
M chrome/common/render_messages_params.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/common/render_messages_params.cc View 4 chunks +5 lines, -0 lines 0 comments Download
M chrome/common/resource_dispatcher.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/renderer/render_view.cc View 2 chunks +3 lines, -1 line 0 comments Download
M webkit/glue/resource_loader_bridge.h View 1 chunk +3 lines, -0 lines 0 comments Download
M webkit/glue/resource_loader_bridge.cc View 1 chunk +2 lines, -1 line 0 comments Download
M webkit/glue/weburlloader_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698