Issue 5603005: Don't unescape backslashes in URLs, since these will be converted to slashes...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5603005: Don't unescape backslashes in URLs, since these will be converted to slashes... (Closed)

Created:
10 years ago by brettw

Modified:
9 years, 7 months ago

Reviewers:
Peter Kasting

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Don't unescape backslashes in URLs, since these will be converted to slashes by googleurl, changing the meaning of the URL. BUG=45051 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68200

Patch Set 1 #

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	net/base/escape.cc	View		2 chunks	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Peter Kasting

LGTM -- but have you considered making googleurl's conversion of \ to / be under ...

10 years ago (2010-12-03 17:42:09 UTC) #2

brettw

10 years ago (2010-12-03 17:52:18 UTC) #3

On Fri, Dec 3, 2010 at 9:42 AM,  <pkasting@chromium.org> wrote:
> LGTM -- but have you considered making googleurl's conversion of \ to / be
> under
> #if OS_WIN?

Yes, I think that's a bad idea. In general people don't know the
difference between / and \ so pages use them randomly in links. This
is why browsers generally convert them.

Brett

Expand Messages | Collapse Messages