Issue 5603004: Use stopped_on_render_loop_ to prevent further work from executing in BufferedDataSource.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5603004: Use stopped_on_render_loop_ to prevent further work from executing in BufferedDataSource. (Closed)

Created:
10 years ago by scherkus (not reviewing)

Modified:
9 years, 7 months ago

Reviewers:
vrk (LEFT CHROMIUM), Alpha Left Google

CC:
chromium-reviews, fbarchard, ddorwin+watch_chromium.org, Alpha Left Google, acolwell GONE FROM CHROMIUM, annacc, darin-cc_chromium.org, awong, scherkus (not reviewing)

Base URL:
svn://chrome-svn/chrome/trunk/src

Visibility:
Public.

Description

Use stopped_on_render_loop_ to prevent further work from executing in BufferedDataSource. Previously we were using it as a DCHECK but we would fail gracefully. Now that stopped_on_render_loop_ is set via Abort() (i.e., catastrophic failure), we need to use it as a singal to make sure all work on the render loop does indeed stop. BUG=16751 TEST=http/tests/media should stop crashing Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68363

Patch Set 1 #

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -19 lines)			Patch
	M	webkit/glue/media/buffered_data_source.h	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	webkit/glue/media/buffered_data_source.cc	View		6 chunks	+6 lines, -18 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

scherkus (not reviewing)

Looks like that CHECK I made annacc add started firing :(

10 years ago (2010-12-03 01:14:33 UTC) #1

LGTM.

Expand Messages | Collapse Messages