Move message flags into a separate header that can be used

Move message flags into a separate header that can be used
outside the views system.  Mac will need this as well when
implementing message boxes.

[sky, 2009-03-27 21:38:40]

http://codereview.chromium.org/56026/diff/1/13
File chrome/common/message_box_flags.h (right):

http://codereview.chromium.org/56026/diff/1/13#newcode11
Line 11: class MessageBox {
Would this be better as namespace named message_box_flags?

http://codereview.chromium.org/56026/diff/1/13#newcode12
Line 12: public:
nit: spacing

http://codereview.chromium.org/56026/diff/1/13#newcode42
Line 42: };
If you keep this as a class, you should make the constructor private.

[tony, 2009-03-27 21:54:08]

brett, knower of all things C++ style related, is it ok for me to use a
namespace named message_box_flags or should I just use static variables in a
class.

Spacing and private constructor fixed.

On 2009/03/27 21:38:40, sky wrote:
> http://codereview.chromium.org/56026/diff/1/13
> File chrome/common/message_box_flags.h (right):
> 
> http://codereview.chromium.org/56026/diff/1/13#newcode11
> Line 11: class MessageBox {
> Would this be better as namespace named message_box_flags?
> 
> http://codereview.chromium.org/56026/diff/1/13#newcode12
> Line 12: public:
> nit: spacing
> 
> http://codereview.chromium.org/56026/diff/1/13#newcode42
> Line 42: };
> If you keep this as a class, you should make the constructor private.

[sky, 2009-03-27 22:15:51]

LGTM