Issue 56016: Fix renderer hang caused when a synchronous XHR is disallowed for security...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 56016: Fix renderer hang caused when a synchronous XHR is disallowed for security... (Closed)

Created:
11 years, 9 months ago by darin (slow to review)

Modified:
9 years, 7 months ago

Reviewers:
jam

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Fix renderer hang caused when a synchronous XHR is disallowed for security reasons (via ShouldServiceReqeuest). BUG=8401 R=jam Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=12675

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+68 lines, -8 lines)			Patch
M	chrome/browser/renderer_host/resource_dispatcher_host.cc	View	1 chunk	+15 lines, -7 lines	0 comments	Download
M	chrome/browser/renderer_host/resource_dispatcher_host_uitest.cc	View	1 chunk	+21 lines, -1 line	0 comments	Download
M	chrome/browser/renderer_host/resource_handler.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
A	chrome/test/data/sync_xmlhttprequest_disallowed.html	View	1 chunk	+29 lines, -0 lines	0 comments	Download
M	webkit/glue/resource_loader_bridge.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

jam

lgtm Are the changes to resource_handler.h and webkit/glue/resource_loader_bridge.cc unrelated?

11 years, 9 months ago (2009-03-27 18:39:49 UTC) #2

darin (slow to review)

11 years, 9 months ago (2009-03-27 18:41:57 UTC) #3

No, they are part of this change.  I wanted to make sure that the SyncLoadResult
was fully initialized before sending it.