Issue 56002: Fix issue 289: check external source strings validity in Runtime_DebugGetLoadedScripts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 56002: Fix issue 289: check external source strings validity in Runtime_DebugGetLoadedScripts (Closed)

Created:
11 years, 9 months ago by Mikhail Naganov

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Visibility:
Public.

Description

Fix issue 289: check external source strings validity in Runtime_DebugGetLoadedScripts Committed: http://code.google.com/p/v8/source/detail?r=1630

Patch Set 2 : don't need return value from CompileRun #

Total comments: 2

Patch Set 3 : Added a comment as Soren suggests #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+56 lines, -1 line)			Patch
	M	src/runtime.cc	View	1 2	2 chunks	+17 lines, -1 line	0 comments	Download
	M	test/cctest/test-debug.cc	View	1	1 chunk	+39 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

LGTM http://codereview.chromium.org/56002/diff/1001/7 File src/runtime.cc (right): http://codereview.chromium.org/56002/diff/1001/7#newcode6511 Line 6511: Please add a comment here describing that ...

11 years, 9 months ago (2009-03-27 10:28:08 UTC) #2

Mikhail Naganov

11 years, 9 months ago (2009-03-27 11:22:01 UTC) #3

http://codereview.chromium.org/56002/diff/1001/7
File src/runtime.cc (right):

http://codereview.chromium.org/56002/diff/1001/7#newcode6511
Line 6511: 
On 2009/03/27 10:28:08, Søren Gjesse wrote:
> Please add a comment here describing that this function only checks external
> strings non external string objects are always considered OK.

Done.