Issue 560005: Make run_remote_test's use of ssh-agent more predictable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 560005: Make run_remote_test's use of ssh-agent more predictable. (Closed)

Created:
10 years, 10 months ago by seano

Modified:
9 years, 7 months ago

Reviewers:
kmixter1, ericli

CC:
chromium-os-reviews_googlegroups.com

Visibility:
Public.

Description

Make run_remote_test's use of ssh-agent more predictable.

Patch Set 2 : addressed style comments #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -5 lines)			Patch
	M	src/scripts/remote_access.sh	View	1	2 chunks	+14 lines, -0 lines	0 comments	Download
	M	src/scripts/run_remote_tests.sh	View		1 chunk	+1 line, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

kmixter1

LGTM Small stylistic comments. http://codereview.chromium.org/560005/diff/1/2 File src/scripts/remote_access.sh (right): http://codereview.chromium.org/560005/diff/1/2#newcode26 src/scripts/remote_access.sh:26: if [ -z "$SSH_AGENT_PID" ]; ...

10 years, 10 months ago (2010-02-02 00:41:31 UTC) #2

seano

10 years, 10 months ago (2010-02-02 00:58:23 UTC) #3

submitting

http://codereview.chromium.org/560005/diff/1/2
File src/scripts/remote_access.sh (right):

http://codereview.chromium.org/560005/diff/1/2#newcode26
src/scripts/remote_access.sh:26: if [ -z "$SSH_AGENT_PID" ]; then
On 2010/02/02 00:41:31, kmixter1 wrote:
> set OWN_SSH_AGENT=0 if not?

Done.

http://codereview.chromium.org/560005/diff/1/2#newcode44
src/scripts/remote_access.sh:44: if [[ "1" == ${OWN_SSH_AGENT} ]]
On 2010/02/02 00:41:31, kmixter1 wrote:
> Maybe [[ 1 -eq ${OWN_SSH_AGENT} ]] because this is an integer comparison?

Done.

Expand Messages | Collapse Messages

Issue 560005: Make run_remote_test's use of ssh-agent more predictable. (Closed)

Description

Patch Set 1 #

Patch Set 2 : addressed style comments #

Messages