Fixed compile/link errors for gpu unit-tests. I had to mostly fix signed/unsi...

Fixed compile/link errors for gpu unit-tests. I had to mostly fix signed/unsigned mismatch and link failures due to non-definition of static member variables. I still do not understand why gcc is behaving arbitrarily for only a few static member variables. AFAIK the standard says that static const numeric types do not need to be defined anymore.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=37837

[alokp, 2010-02-01 22:38:12]

All 514 tests passes. The debug build takes < 1 sec to run:
real	0m0.469s
user	0m0.368s
sys	0m0.020s

[greggman, 2010-02-01 22:53:35]

http://codereview.chromium.org/560002/diff/1/7
File gpu/command_buffer/common/GLES2/gl2types.h (right):

http://codereview.chromium.org/560002/diff/1/7#newcode150
gpu/command_buffer/common/GLES2/gl2types.h:150: #define GL_NO_ERROR             
         0u
These defines should probably not change as they may cause errors in other
people's code.

[alokp, 2010-02-01 23:25:06]

http://codereview.chromium.org/560002/diff/1/7
File gpu/command_buffer/common/GLES2/gl2types.h (right):

http://codereview.chromium.org/560002/diff/1/7#newcode150
gpu/command_buffer/common/GLES2/gl2types.h:150: #define GL_NO_ERROR             
         0u
I have reverted this change. I have changed GLES2DecoderTest::GetGLError() to
return GLint instead of GLenum.

[greggman, 2010-02-01 23:29:21]

http://codereview.chromium.org/560002/diff/1/7
File gpu/command_buffer/common/GLES2/gl2types.h (right):

http://codereview.chromium.org/560002/diff/1/7#newcode150
gpu/command_buffer/common/GLES2/gl2types.h:150: #define GL_NO_ERROR             
         0u
On 2010/02/01 23:25:06, alokp wrote:
> I have reverted this change. I have changed GLES2DecoderTest::GetGLError() to
> return GLint instead of GLenum.

I don't think you can make that change either?  GL defines glGetError as
returning GLenum so it seems like GetGLError should also continue to return
GLenum.

[alokp, 2010-02-01 23:34:19]

http://codereview.chromium.org/560002/diff/1/7
File gpu/command_buffer/common/GLES2/gl2types.h (right):

http://codereview.chromium.org/560002/diff/1/7#newcode150
gpu/command_buffer/common/GLES2/gl2types.h:150: #define GL_NO_ERROR             
         0u
This change is localized to gles2_cmd_decoder_unittest.cc and only affects
unit-tests in that file. If it is not acceptable, I will have to do a type-cast
everywhere GetGLError is called.

[greggman, 2010-02-01 23:56:39]

http://codereview.chromium.org/560002/diff/1/7
File gpu/command_buffer/common/GLES2/gl2types.h (right):

http://codereview.chromium.org/560002/diff/1/7#newcode150
gpu/command_buffer/common/GLES2/gl2types.h:150: #define GL_NO_ERROR             
         0u
On 2010/02/01 23:34:19, alokp wrote:
> This change is localized to gles2_cmd_decoder_unittest.cc and only affects
> unit-tests in that file. If it is not acceptable, I will have to do a
type-cast
> everywhere GetGLError is called.

Yea, ok then