Issue 5600001: Clean up when Chrome is terminated and WizardController is in charge of the message loop.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5600001: Clean up when Chrome is terminated and WizardController is in charge of the message loop. (Closed)

Created:
10 years ago by whywhat

Modified:
9 years, 7 months ago

Reviewers:
oshima

CC:
chromium-reviews, nkostylev+cc_chromium.org, davemoore+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Clean up when Chrome is terminated and WizardController is in charge of the message loop. BUG=chromium-os:7295 TEST=Login with a new user, lock screen on profile picture step, sign out, login as the same user, verify there's no crash infobar shown. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68344

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed comment #

Patch Set 3 : Added CHECK to catch possible bugs #

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -1 line)			Patch
	M	chrome/browser/chromeos/login/wizard_controller.h	View		4 chunks	+11 lines, -1 line	0 comments	Download
	M	chrome/browser/chromeos/login/wizard_controller.cc	View	1	3 chunks	+17 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

oshima

LGTM if you agree below. http://codereview.chromium.org/5600001/diff/1/chrome/browser/chromeos/login/wizard_controller.cc File chrome/browser/chromeos/login/wizard_controller.cc (right): http://codereview.chromium.org/5600001/diff/1/chrome/browser/chromeos/login/wizard_controller.cc#newcode524 chrome/browser/chromeos/login/wizard_controller.cc:524: if (type == NotificationType::APP_TERMINATING) ...

10 years ago (2010-12-02 19:40:36 UTC) #2

whywhat

10 years ago (2010-12-03 10:36:56 UTC) #3

http://codereview.chromium.org/5600001/diff/1/chrome/browser/chromeos/login/w...
File chrome/browser/chromeos/login/wizard_controller.cc (right):

http://codereview.chromium.org/5600001/diff/1/chrome/browser/chromeos/login/w...
chrome/browser/chromeos/login/wizard_controller.cc:524: if (type ==
NotificationType::APP_TERMINATING) {
On 2010/12/02 19:40:36, oshima wrote:
> i prefer CHECK because we can catch error.

Done.

Expand Messages | Collapse Messages